From mboxrd@z Thu Jan 1 00:00:00 1970 From: Trond Myklebust Subject: Re: [PATCH 1/4] VFS: Add a VFS helper function vfs_remote_path_lookup() Date: Thu, 02 Apr 2009 17:10:11 -0400 Message-ID: <1238706611.31262.8.camel@heimdal.trondhjem.org> References: <20090401233252.GH28946@ZenIV.linux.org.uk> <1238629407.19782.5.camel@heimdal.trondhjem.org> <20090402191709.GJ28946@ZenIV.linux.org.uk> <1238700874.16087.42.camel@heimdal.trondhjem.org> <20090402195212.GK28946@ZenIV.linux.org.uk> <20090402195759.GL28946@ZenIV.linux.org.uk> <20090402202846.GM28946@ZenIV.linux.org.uk> <1238705130.16087.58.camel@heimdal.trondhjem.org> <20090402205418.GN28946@ZenIV.linux.org.uk> <20090402205618.GO28946@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Linus Torvalds , linux-fsdevel@vger.kernel.org To: Al Viro Return-path: Received: from mx2.netapp.com ([216.240.18.37]:36231 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751588AbZDBVKp (ORCPT ); Thu, 2 Apr 2009 17:10:45 -0400 In-Reply-To: <20090402205618.GO28946@ZenIV.linux.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, 2009-04-02 at 21:56 +0100, Al Viro wrote: > On Thu, Apr 02, 2009 at 09:54:18PM +0100, Al Viro wrote: > > On Thu, Apr 02, 2009 at 04:45:30PM -0400, Trond Myklebust wrote: > > > > > The NFS client is constructing the namespace as it walks the path using > > > the ->follow_link() trick to automount new filesystems. As long as we > > > can add a mount namespace argument to do_add_mount(), then we should be > > > able to make use of a namespace in struct nameidata. > > > > *wince* > > Theoretically doable, practically can get ugly. > > BTW, it's enough to tell it "take the namespace mountpoint belongs to", > if we really go that way. True. The only place (apart from check_mnt()) that doesn't use the mountpoint namespace appears to be attach_recursive_mnt() which, for reasons which are not clear, appears to do a touch_mnt_namespace() on current->nsproxy->mnt_ns instead. -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@netapp.com www.netapp.com