From mboxrd@z Thu Jan  1 00:00:00 1970
From: Trond Myklebust <Trond.Myklebust@netapp.com>
Subject: Re: [PATCH 3/2] [RFC] NFS: Support the AT_NO_TIMES and AT_STRICT
 fstatat flags
Date: Tue, 07 Apr 2009 16:07:00 -0700
Message-ID: <1239145620.8424.12.camel@heimdal.trondhjem.org>
References: <20090407080107.GR14571@wotan.suse.de>
	 <1239142685.8424.9.camel@heimdal.trondhjem.org>
	 <C06B4C94-A44E-48D4-874E-BE3F06FDBB5F@linuxhacker.ru>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: Mark Fasheh <mfasheh@suse.com>, linux-fsdevel@vger.kernel.org,
	Sage Weil <sage@newdream.net>, Andreas Dilger <adilger@sun.com>
To: Oleg Drokin <green@linuxhacker.ru>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mx2.netapp.com ([216.240.18.37]:43114 "EHLO mx2.netapp.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751349AbZDGXHd (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 7 Apr 2009 19:07:33 -0400
In-Reply-To: <C06B4C94-A44E-48D4-874E-BE3F06FDBB5F@linuxhacker.ru>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, 2009-04-07 at 18:47 -0400, Oleg Drokin wrote:
> Hello!
> 
> On Apr 7, 2009, at 6:18 PM, Trond Myklebust wrote:
> 
> > +	if (!(flags & AT_NO_TIMES))
> > +		goto do_revalidate;
> 
> This is already a shortcoming of the less-fine grained control.
> Suppose a normal ls -l command, it does not care about atimes,
> only mtimes, but there is no way to specify it and NFS only
> cares if atimes were requested or not.

I agree that an explicit AT_NO_ATIME might be useful.

Cheers
  Trond
-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com