From: Trond Myklebust <trond.myklebust-41N18TsMXrtuMpJDpNschA@public.gmane.org>
To: Nick Piggin <npiggin-l3A5Bk7waGM@public.gmane.org>
Cc: linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Linux Filesystem Development
<linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Why doesn't zap_pte_range() call page_mkwrite()
Date: Thu, 23 Apr 2009 14:17:48 -0400 [thread overview]
Message-ID: <1240510668.11148.40.camel@heimdal.trondhjem.org> (raw)
Hi Nick,
I'm still working on the bug in
http://bugzilla.kernel.org/show_bug.cgi?id=12913 . One other source of
grief appears to be munmap(), which is calling set_page_dirty() on a
number of pages without locking them or first calling page_mkwrite().
Currently, this means that we either ignore that dirty bit (since
nfs_page_async_flush() won't find a corresponding write request) or it
too can end up triggering the PG_CLEAN BUG() in fs/nfs/write.c:252 if
the timing is right.
So what is the reason why zap_pte_range() calls set_page_dirty()
directly?
Cheers
Trond
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2009-04-23 18:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 18:17 Trond Myklebust [this message]
[not found] ` <1240510668.11148.40.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-04-23 19:52 ` Why doesn't zap_pte_range() call page_mkwrite() Miklos Szeredi
[not found] ` <E1Lx4yU-0007A8-Gl-8f8m9JG5TPIdUIPVzhDTVZP2KDSNp7ea@public.gmane.org>
2009-04-23 20:42 ` Trond Myklebust
2009-04-24 7:15 ` Miklos Szeredi
[not found] ` <E1LxFd4-0008Ih-Rd-8f8m9JG5TPIdUIPVzhDTVZP2KDSNp7ea@public.gmane.org>
2009-04-24 7:33 ` Miklos Szeredi
2009-04-24 12:59 ` Chris Mason
2009-04-24 13:31 ` Trond Myklebust
2009-04-24 14:06 ` Trond Myklebust
2009-04-24 16:18 ` Jamie Lokier
2009-04-24 10:41 ` Robin Holt
2009-04-24 14:52 ` Miklos Szeredi
[not found] ` <E1LxMlO-0000sU-1J-8f8m9JG5TPIdUIPVzhDTVZP2KDSNp7ea@public.gmane.org>
2009-04-24 17:00 ` Trond Myklebust
[not found] ` <1240592448.4946.35.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-04-25 5:10 ` Nick Piggin
2009-09-08 15:30 ` Chris Mason
2009-09-08 15:41 ` Nick Piggin
[not found] ` <20090908154132.GC29902@wotan.suse.de>
2009-09-08 16:31 ` Chris Mason
2009-09-08 17:00 ` Nick Piggin
2009-09-09 2:21 ` Christoph Hellwig
[not found] ` <20090909022102.GA28318@infradead.org>
[not found] ` <20090909022102.GA28318-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2009-09-09 5:39 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240510668.11148.40.camel@heimdal.trondhjem.org \
--to=trond.myklebust-41n18tsmxrtumpjdpnscha@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=npiggin-l3A5Bk7waGM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).