From mboxrd@z Thu Jan 1 00:00:00 1970 From: Trond Myklebust Subject: Why doesn't zap_pte_range() call page_mkwrite() Date: Thu, 23 Apr 2009 14:17:48 -0400 Message-ID: <1240510668.11148.40.camel@heimdal.trondhjem.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux Filesystem Development To: Nick Piggin Return-path: Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org Hi Nick, I'm still working on the bug in http://bugzilla.kernel.org/show_bug.cgi?id=12913 . One other source of grief appears to be munmap(), which is calling set_page_dirty() on a number of pages without locking them or first calling page_mkwrite(). Currently, this means that we either ignore that dirty bit (since nfs_page_async_flush() won't find a corresponding write request) or it too can end up triggering the PG_CLEAN BUG() in fs/nfs/write.c:252 if the timing is right. So what is the reason why zap_pte_range() calls set_page_dirty() directly? Cheers Trond -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html