From: Alessio Igor Bogani <abogani@texware.it>
To: Ingo Molnar <mingo@elte.hu>
Cc: "Jonathan Corbet" <corbet@lwn.net>,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
LKML <linux-kernel@vger.kernel.org>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
LFSDEV <linux-fsdevel@vger.kernel.org>,
"Alessio Igor Bogani" <abogani@texware.it>
Subject: [PATCH 2/5 -tip] cifs: umount_begin BKL pushdown
Date: Thu, 23 Apr 2009 21:12:02 +0200 [thread overview]
Message-ID: <1240513925-5603-3-git-send-email-abogani@texware.it> (raw)
In-Reply-To: <1240513925-5603-2-git-send-email-abogani@texware.it>
Signed-off-by: Alessio Igor Bogani <abogani@texware.it>
---
fs/cifs/cifsfs.c | 13 +++++++++++--
1 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
index 38491fd..9517ae1 100644
--- a/fs/cifs/cifsfs.c
+++ b/fs/cifs/cifsfs.c
@@ -35,6 +35,7 @@
#include <linux/delay.h>
#include <linux/kthread.h>
#include <linux/freezer.h>
+#include <linux/smp_lock.h>
#include "cifsfs.h"
#include "cifspdu.h"
#define DECLARE_GLOBALS_HERE
@@ -525,18 +526,26 @@ static void cifs_umount_begin(struct super_block *sb)
struct cifs_sb_info *cifs_sb = CIFS_SB(sb);
struct cifsTconInfo *tcon;
- if (cifs_sb == NULL)
+ lock_kernel();
+
+ if (cifs_sb == NULL) {
+ unlock_kernel();
return;
+ }
tcon = cifs_sb->tcon;
- if (tcon == NULL)
+ if (tcon == NULL) {
+ unlock_kernel();
return;
+ }
read_lock(&cifs_tcp_ses_lock);
if (tcon->tc_count == 1)
tcon->tidStatus = CifsExiting;
read_unlock(&cifs_tcp_ses_lock);
+ unlock_kernel();
+
/* cancel_brl_requests(tcon); */ /* BB mark all brl mids as exiting */
/* cancel_notify_requests(tcon); */
if (tcon->ses && tcon->ses->server) {
--
1.6.0.4
next prev parent reply other threads:[~2009-04-23 19:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 19:12 [PATCH 0/5 -tip] umount_begin BKL pushdown Alessio Igor Bogani
2009-04-23 19:12 ` [PATCH 1/5 -tip] 9p: " Alessio Igor Bogani
2009-04-23 19:12 ` Alessio Igor Bogani [this message]
2009-04-23 19:12 ` [PATCH 3/5 -tip] fuse: " Alessio Igor Bogani
2009-04-23 19:12 ` [PATCH 4/5 -tip] nfs: " Alessio Igor Bogani
2009-04-23 19:12 ` [PATCH 5/5 -tip] vfs: Don-t call umount_begin with BKL held Alessio Igor Bogani
2009-04-23 19:15 ` [PATCH 2/5 -tip] cifs: umount_begin BKL pushdown Al Viro
2009-04-23 19:19 ` Matthew Wilcox
2009-04-24 7:06 ` [PATCH 0/1] vfs: umount_begin BKL pushdown v2 Alessio Igor Bogani
2009-04-24 7:06 ` [PATCH 1/1] " Alessio Igor Bogani
2009-04-24 7:13 ` Al Viro
2009-04-24 7:15 ` Al Viro
2009-04-24 8:48 ` Christoph Hellwig
2009-04-24 7:18 ` Al Viro
2009-04-24 7:41 ` Alessio Igor Bogani
2009-04-24 8:06 ` Ingo Molnar
2009-04-24 8:50 ` Christoph Hellwig
2009-04-24 9:16 ` Frédéric Weisbecker
2009-04-24 17:50 ` Christoph Hellwig
2009-04-24 18:55 ` Al Viro
2009-04-24 19:02 ` Christoph Hellwig
2009-04-24 20:43 ` Al Viro
2009-04-24 22:07 ` Ingo Molnar
2009-04-24 22:49 ` Ingo Molnar
2009-04-24 13:58 ` Al Viro
2009-04-24 22:19 ` Ingo Molnar
2009-04-25 7:16 ` Al Viro
2009-04-23 19:18 ` [PATCH 0/5 -tip] umount_begin BKL pushdown Al Viro
2009-04-23 21:32 ` Ingo Molnar
2009-04-24 1:57 ` Stephen Rothwell
2009-04-24 14:31 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240513925-5603-3-git-send-email-abogani@texware.it \
--to=abogani@texware.it \
--cc=a.p.zijlstra@chello.nl \
--cc=corbet@lwn.net \
--cc=fweisbec@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).