From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alessio Igor Bogani Subject: [PATCH 5/5 -tip] vfs: Don-t call umount_begin with BKL held Date: Thu, 23 Apr 2009 21:12:05 +0200 Message-ID: <1240513925-5603-6-git-send-email-abogani@texware.it> References: <1240513925-5603-1-git-send-email-abogani@texware.it> <1240513925-5603-2-git-send-email-abogani@texware.it> <1240513925-5603-3-git-send-email-abogani@texware.it> <1240513925-5603-4-git-send-email-abogani@texware.it> <1240513925-5603-5-git-send-email-abogani@texware.it> Cc: Jonathan Corbet , =?utf-8?q?Fr=C3=A9d=C3=A9ric=20Weisbecker?= , Peter Zijlstra , LKML , Alexander Viro , LFSDEV , Alessio Igor Bogani To: Ingo Molnar Return-path: Received: from mail-fx0-f158.google.com ([209.85.220.158]:61329 "EHLO mail-fx0-f158.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758909AbZDWTMV (ORCPT ); Thu, 23 Apr 2009 15:12:21 -0400 In-Reply-To: <1240513925-5603-5-git-send-email-abogani@texware.it> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Every filesystem should acquire BKL or provide an adeguate locking mechanism. Signed-off-by: Alessio Igor Bogani --- fs/namespace.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/fs/namespace.c b/fs/namespace.c index c6f54e4..f046f4b 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -1073,9 +1073,7 @@ static int do_umount(struct vfsmount *mnt, int flags) */ if (flags & MNT_FORCE && sb->s_op->umount_begin) { - lock_kernel(); sb->s_op->umount_begin(sb); - unlock_kernel(); } /* -- 1.6.0.4