linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alessio Igor Bogani <abogani@texware.it>
To: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: "Jonathan Corbet" <corbet@lwn.net>,
	"Frédéric Weisbecker" <fweisbec@gmail.com>,
	"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
	LKML <linux-kernel@vger.kernel.org>,
	LFSDEV <linux-fsdevel@vger.kernel.org>,
	"Ingo Molnar" <mingo@elte.hu>, "Matthew Wilcox" <matthew@wil.cx>,
	"Alessio Igor Bogani" <abogani@texware.it>
Subject: [PATCH 0/1] vfs: umount_begin BKL pushdown v2
Date: Fri, 24 Apr 2009 09:06:52 +0200	[thread overview]
Message-ID: <1240556813-8739-1-git-send-email-abogani@texware.it> (raw)
In-Reply-To: <20090423191934.GW1926@parisc-linux.org>

Push the BKL acquisition from vfs to every specific filesystems
with hope that it can be eliminated in a second moment.

Filesystems, which support umount_begin(), changed by this patch
are 9p, nfs, cifs and fuse. 

Changes:
Collapsed all patches into only one as requested by Al Viro.

Moved CIFS_SB() down into BKL protected zone as requested by Matthew Wilcox.

It is hard to say if tcon (into cifs's umount_begin() function) should be
protected by BKL. Up to now umount_begin() is always called with BKL held
so in uncertainty I maintain same logic. So I moved unlock_kernel() to at
the bottom of that function as requested by Al Viro and Matthew Wilcox.

Notes:
About cifs's umount_begin() function I suspect that a deadlock or circular
locking dependency can happens into kill-the-BKL tree if that patch is applied.

  reply	other threads:[~2009-04-24  7:07 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-23 19:12 [PATCH 0/5 -tip] umount_begin BKL pushdown Alessio Igor Bogani
2009-04-23 19:12 ` [PATCH 1/5 -tip] 9p: " Alessio Igor Bogani
2009-04-23 19:12   ` [PATCH 2/5 -tip] cifs: " Alessio Igor Bogani
2009-04-23 19:12     ` [PATCH 3/5 -tip] fuse: " Alessio Igor Bogani
2009-04-23 19:12       ` [PATCH 4/5 -tip] nfs: " Alessio Igor Bogani
2009-04-23 19:12         ` [PATCH 5/5 -tip] vfs: Don-t call umount_begin with BKL held Alessio Igor Bogani
2009-04-23 19:15     ` [PATCH 2/5 -tip] cifs: umount_begin BKL pushdown Al Viro
2009-04-23 19:19     ` Matthew Wilcox
2009-04-24  7:06       ` Alessio Igor Bogani [this message]
2009-04-24  7:06         ` [PATCH 1/1] vfs: umount_begin BKL pushdown v2 Alessio Igor Bogani
2009-04-24  7:13           ` Al Viro
2009-04-24  7:15             ` Al Viro
2009-04-24  8:48               ` Christoph Hellwig
2009-04-24  7:18             ` Al Viro
2009-04-24  7:41               ` Alessio Igor Bogani
2009-04-24  8:06               ` Ingo Molnar
2009-04-24  8:50                 ` Christoph Hellwig
2009-04-24  9:16                   ` Frédéric Weisbecker
2009-04-24 17:50                     ` Christoph Hellwig
2009-04-24 18:55                       ` Al Viro
2009-04-24 19:02                         ` Christoph Hellwig
2009-04-24 20:43                           ` Al Viro
2009-04-24 22:07                       ` Ingo Molnar
2009-04-24 22:49                   ` Ingo Molnar
2009-04-24 13:58                 ` Al Viro
2009-04-24 22:19                   ` Ingo Molnar
2009-04-25  7:16                     ` Al Viro
2009-04-23 19:18 ` [PATCH 0/5 -tip] umount_begin BKL pushdown Al Viro
2009-04-23 21:32   ` Ingo Molnar
2009-04-24  1:57     ` Stephen Rothwell
2009-04-24 14:31       ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1240556813-8739-1-git-send-email-abogani@texware.it \
    --to=abogani@texware.it \
    --cc=a.p.zijlstra@chello.nl \
    --cc=corbet@lwn.net \
    --cc=fweisbec@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=mingo@elte.hu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).