Re: [PATCH 3/5] gfs2: remove ->write_super and stop maintaining ->s_dirt

[Steven Whitehouse <steve@chygwyn.com>]

Hi,

Acked-by: Steven Whitehouse <swhiteho@redhat.com>

Steve.

On Mon, 2009-04-27 at 09:46 -0400, Christoph Hellwig wrote:
> plain text document attachment (gfs2-remove-write_super)
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Index: linux-2.6/fs/gfs2/log.c
> ===================================================================
> --- linux-2.6.orig/fs/gfs2/log.c	2009-04-26 20:16:25.197978791 +0200
> +++ linux-2.6/fs/gfs2/log.c	2009-04-26 20:16:33.128077096 +0200
> @@ -764,7 +764,6 @@ void __gfs2_log_flush(struct gfs2_sbd *s
>  	}
>  	gfs2_log_unlock(sdp);
>  
> -	sdp->sd_vfs->s_dirt = 0;
>  	up_write(&sdp->sd_log_flush_lock);
>  
>  	kfree(ai);
> @@ -823,7 +822,6 @@ void gfs2_log_commit(struct gfs2_sbd *sd
>  	log_refund(sdp, tr);
>  	buf_lo_incore_commit(sdp, tr);
>  
> -	sdp->sd_vfs->s_dirt = 1;
>  	up_read(&sdp->sd_log_flush_lock);
>  
>  	gfs2_log_lock(sdp);
> Index: linux-2.6/fs/gfs2/ops_super.c
> ===================================================================
> --- linux-2.6.orig/fs/gfs2/ops_super.c	2009-04-26 20:16:36.808074171 +0200
> +++ linux-2.6/fs/gfs2/ops_super.c	2009-04-26 20:16:49.267951560 +0200
> @@ -185,17 +185,6 @@ static void gfs2_put_super(struct super_
>  }
>  
>  /**
> - * gfs2_write_super
> - * @sb: the superblock
> - *
> - */
> -
> -static void gfs2_write_super(struct super_block *sb)
> -{
> -	sb->s_dirt = 0;
> -}
> -
> -/**
>   * gfs2_sync_fs - sync the filesystem
>   * @sb: the superblock
>   *
> @@ -204,7 +193,6 @@ static void gfs2_write_super(struct supe
>  
>  static int gfs2_sync_fs(struct super_block *sb, int wait)
>  {
> -	sb->s_dirt = 0;
>  	if (wait && sb->s_fs_info)
>  		gfs2_log_flush(sb->s_fs_info, NULL);
>  	return 0;
> @@ -710,7 +698,6 @@ const struct super_operations gfs2_super
>  	.write_inode		= gfs2_write_inode,
>  	.delete_inode		= gfs2_delete_inode,
>  	.put_super		= gfs2_put_super,
> -	.write_super		= gfs2_write_super,
>  	.sync_fs		= gfs2_sync_fs,
>  	.freeze_fs 		= gfs2_freeze,
>  	.unfreeze_fs		= gfs2_unfreeze,
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-