From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Smalley Subject: Re: New reflink(2) syscall Date: Wed, 06 May 2009 07:23:21 -0400 Message-ID: <1241609001.27629.1.camel@localhost.localdomain> References: <1241443016.3023.51.camel@localhost.localdomain> <1241456379.3023.173.camel@localhost.localdomain> <20090505180024.GI7835@mail.oracle.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Joel Becker , lsm , linux-fsdevel@vger.kernel.org To: James Morris Return-path: Received: from msux-gh1-uea01.nsa.gov ([63.239.67.1]:52200 "EHLO msux-gh1-uea01.nsa.gov" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753954AbZEFL3x (ORCPT ); Wed, 6 May 2009 07:29:53 -0400 In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, 2009-05-06 at 08:15 +1000, James Morris wrote: > On Tue, 5 May 2009, Joel Becker wrote: > > > On Mon, May 04, 2009 at 12:59:39PM -0400, Stephen Smalley wrote: > > > On Tue, 2009-05-05 at 01:35 +1000, James Morris wrote: > > > > Agreed, perhaps something like: > > > > > > > > int security_inode_reflink(struct dentry *dentry, struct inode *dir); > > > > > > I'd pass the same arguments as vfs_reflink(), i.e. old_dentry, dir, > > > new_dentry. > > > > I'm about to insert this bit. I agree with > > security_inode_reflink(old_dentry, dir, new_dentry), > > If the files and metadata are initially identical (except for inode #), > why do we need to see both the old and new dentry? Fair enough - he can drop the new_dentry argument. selinux_inode_link() doesn't use the new_dentry argument to security_inode_link() either. -- Stephen Smalley National Security Agency