linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Christoph Hellwig <hch@lst.de>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/2] jffs2: move jffs2_write_super to super.c
Date: Mon, 11 May 2009 22:36:50 +0100	[thread overview]
Message-ID: <1242077810.24436.388.camel@macbook.infradead.org> (raw)
In-Reply-To: <20090511213427.GA19326@lst.de>

On Mon, 2009-05-11 at 23:34 +0200, Christoph Hellwig wrote:
> jffs2_write_super is only called from super.c and doesn't use any
> functionality from fs.c.  So move it over to super.c and make it
> static there.
> 
> [should go in through the vfs tree as it is a requirement for the
>  next patch]
> 
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Acked-by: David Woodhouse <David.Woodhouse@intel.com>

There are sometimes Linux-specific files split from generic files, which
supports ports like eCos. But this isn't one of those cases. And I'm
less inclined to care these days anyway -- I don't think eCos has
updated from our tree for ages now.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation


      reply	other threads:[~2009-05-11 21:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-11 21:34 [PATCH 1/2] jffs2: move jffs2_write_super to super.c Christoph Hellwig
2009-05-11 21:36 ` David Woodhouse [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1242077810.24436.388.camel@macbook.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).