From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Woodhouse Subject: Re: [PATCH 1/2] jffs2: move jffs2_write_super to super.c Date: Mon, 11 May 2009 22:36:50 +0100 Message-ID: <1242077810.24436.388.camel@macbook.infradead.org> References: <20090511213427.GA19326@lst.de> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from casper.infradead.org ([85.118.1.10]:50342 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753000AbZEKVgx (ORCPT ); Mon, 11 May 2009 17:36:53 -0400 In-Reply-To: <20090511213427.GA19326@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, 2009-05-11 at 23:34 +0200, Christoph Hellwig wrote: > jffs2_write_super is only called from super.c and doesn't use any > functionality from fs.c. So move it over to super.c and make it > static there. > > [should go in through the vfs tree as it is a requirement for the > next patch] > > > Signed-off-by: Christoph Hellwig Acked-by: David Woodhouse There are sometimes Linux-specific files split from generic files, which supports ports like eCos. But this isn't one of those cases. And I'm less inclined to care these days anyway -- I don't think eCos has updated from our tree for ages now. -- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation