From: Artem Bityutskiy <dedekind@infradead.org>
To: hooanon05@yahoo.co.jp
Cc: ext-adrian.hunter@nokia.com, linux-fsdevel@vger.kernel.org
Subject: Re: ubifs, race between link and unlink/rename?
Date: Fri, 15 May 2009 11:44:20 +0300 [thread overview]
Message-ID: <1242377060.27996.225.camel@localhost.localdomain> (raw)
In-Reply-To: <9917.1242232308@jrobl>
On Thu, 2009-05-14 at 01:31 +0900, hooanon05@yahoo.co.jp wrote:
> diff --git a/fs/namei.c b/fs/namei.c
> index b207821..820c386 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -2409,9 +2409,12 @@ int vfs_link(struct dentry *old_dentry, struct inode *dir, struct dentry *new_de
> if (error)
> return error;
>
> + error = -ENOENT;
> mutex_lock(&inode->i_mutex);
> - DQUOT_INIT(dir);
> - error = dir->i_op->link(old_dentry, dir, new_dentry);
> + if (inode->i_nlink) {
> + DQUOT_INIT(dir);
> + error = dir->i_op->link(old_dentry, dir, new_dentry);
> + }
> mutex_unlock(&inode->i_mutex);
> if (!error)
> fsnotify_link(dir, inode, new_dentry);
>
Looks correct to me. I wonder what VFS guys think - should we fix UBIFS
or this can be done at the VFS layer?
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-05-15 8:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-13 16:31 ubifs, race between link and unlink/rename? hooanon05
2009-05-13 18:28 ` Adrian Hunter
2009-05-15 8:44 ` Artem Bityutskiy [this message]
2009-05-15 9:35 ` Artem Bityutskiy
2009-05-19 6:09 ` Artem Bityutskiy
2009-05-19 6:18 ` hooanon05
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242377060.27996.225.camel@localhost.localdomain \
--to=dedekind@infradead.org \
--cc=ext-adrian.hunter@nokia.com \
--cc=hooanon05@yahoo.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).