linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@redhat.com>
To: linux-cifs-client@lists.samba.org, linux-fsdevel@vger.kernel.org
Subject: [PATCH 09/10] cifs: remove cifsInodeInfo->inUse counter
Date: Wed, 27 May 2009 16:34:06 -0400	[thread overview]
Message-ID: <1243456447-11176-10-git-send-email-jlayton@redhat.com> (raw)
In-Reply-To: <1243456447-11176-1-git-send-email-jlayton@redhat.com>

It was purported to be a refcounter of some sort, but was never
used that way. It never served any purpose that wasn't served equally well
by the I_NEW flag.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
 fs/cifs/cifsfs.c   |    1 -
 fs/cifs/cifsglob.h |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
index 0a10a59..3a54565 100644
--- a/fs/cifs/cifsfs.c
+++ b/fs/cifs/cifsfs.c
@@ -304,7 +304,6 @@ cifs_alloc_inode(struct super_block *sb)
 	if (!cifs_inode)
 		return NULL;
 	cifs_inode->cifsAttrs = 0x20;	/* default */
-	atomic_set(&cifs_inode->inUse, 0);
 	cifs_inode->time = 0;
 	cifs_inode->write_behind_rc = 0;
 	/* Until the file is open and we have gotten oplock
diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
index 2f18ac4..3e7134e 100644
--- a/fs/cifs/cifsglob.h
+++ b/fs/cifs/cifsglob.h
@@ -364,7 +364,6 @@ struct cifsInodeInfo {
 	struct list_head openFileList;
 	int write_behind_rc;
 	__u32 cifsAttrs; /* e.g. DOS archive bit, sparse, compressed, system */
-	atomic_t inUse;	 /* num concurrent users (local openers cifs) of file*/
 	unsigned long time;	/* jiffies of last update/check of inode */
 	bool clientCanCacheRead:1;	/* read oplock */
 	bool clientCanCacheAll:1;	/* read and writebehind oplock */
-- 
1.6.2.2


  parent reply	other threads:[~2009-05-27 20:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-27 20:33 [PATCH 00/10] cifs: implement proper hardlink handling (try #5) Jeff Layton
2009-05-27 20:33 ` [PATCH 01/10] cifs: have cifs_NTtimeToUnix take a little-endian arg Jeff Layton
2009-05-27 20:33 ` [PATCH 02/10] cifs: make cnvrtDosUnixTm take a little-endian args and an offset Jeff Layton
2009-05-27 20:34 ` [PATCH 03/10] cifs: reorganize get_cifs_acl Jeff Layton
2009-05-28 15:23   ` Shirish Pargaonkar
2009-05-27 20:34 ` [PATCH 04/10] cifs: clean up set_cifs_acl interfaces Jeff Layton
2009-05-28 15:23   ` [linux-cifs-client] " Shirish Pargaonkar
2009-05-27 20:34 ` [PATCH 05/10] cifs: rename cifs_iget to cifs_root_iget Jeff Layton
2009-05-27 20:34 ` [PATCH 06/10] cifs: add new cifs_iget function and convert unix codepath to use it Jeff Layton
2009-05-27 20:34 ` [PATCH 07/10] cifs: convert cifs_get_inode_info and non-posix readdir to use cifs_iget Jeff Layton
2009-05-27 20:34 ` [PATCH 08/10] cifs: make serverino the default when mounting Jeff Layton
2009-05-27 20:34 ` Jeff Layton [this message]
2009-05-27 20:34 ` [PATCH 10/10] cifs: remove "hardlink detection" from cifs_rename Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1243456447-11176-10-git-send-email-jlayton@redhat.com \
    --to=jlayton@redhat.com \
    --cc=linux-cifs-client@lists.samba.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).