linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind@infradead.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>,
	Artem Bityutskiy <Artem.Bityutskiy@nokia.com>,
	Al Viro <viro@ZenIV.linux.org.uk>
Subject: [PATCH v2.1 17/17] VFS: use is_sb_dirty helper
Date: Fri,  5 Jun 2009 16:05:55 +0300	[thread overview]
Message-ID: <1244207155-2092-18-git-send-email-dedekind@infradead.org> (raw)
In-Reply-To: <1244207155-2092-1-git-send-email-dedekind@infradead.org>

From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

... instead of checking 's_dirt' directly. This is just
a little cleaner and more consistent. We have only 3
VFS helpers which access 's_dirt' now.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
---
 fs/super.c |    4 ++--
 fs/sync.c  |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/super.c b/fs/super.c
index 2ea1586..ef9a24a 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -415,12 +415,12 @@ void sync_supers(void)
 	spin_lock(&sb_lock);
 restart:
 	list_for_each_entry(sb, &super_blocks, s_list) {
-		if (sb->s_op->write_super && sb->s_dirt) {
+		if (sb->s_op->write_super && is_sb_dirty(sb)) {
 			sb->s_count++;
 			spin_unlock(&sb_lock);
 
 			down_read(&sb->s_umount);
-			if (sb->s_root && sb->s_dirt)
+			if (sb->s_root && is_sb_dirty(sb))
 				sb->s_op->write_super(sb);
 			up_read(&sb->s_umount);
 
diff --git a/fs/sync.c b/fs/sync.c
index e9d56f6..12f36d7 100644
--- a/fs/sync.c
+++ b/fs/sync.c
@@ -33,7 +33,7 @@ static int __sync_filesystem(struct super_block *sb, int wait)
 	else
 		sync_quota_sb(sb, -1);
 	sync_inodes_sb(sb, wait);
-	if (sb->s_dirt && sb->s_op->write_super)
+	if (is_sb_dirty(sb) && sb->s_op->write_super)
 		sb->s_op->write_super(sb);
 	if (sb->s_op->sync_fs)
 		sb->s_op->sync_fs(sb, wait);
@@ -162,7 +162,7 @@ int file_fsync(struct file *filp, struct dentry *dentry, int datasync)
 
 	/* sync the superblock to buffers */
 	sb = inode->i_sb;
-	if (sb->s_dirt && sb->s_op->write_super)
+	if (is_sb_dirty(sb) && sb->s_op->write_super)
 		sb->s_op->write_super(sb);
 
 	/* .. finally sync the buffers to disk */
-- 
1.6.0.6


      parent reply	other threads:[~2009-06-05 11:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-05 13:05 [PATCH v2.1 00/17] abstract out the super block clean/dirty state Artem Bityutskiy
2009-06-05 13:05 ` [PATCH v2.1 01/17] VFS: introduce helpers for manipulation s_dirty flag Artem Bityutskiy
2009-06-05 13:05 ` [PATCH v2.1 02/17] AFFS: do not manipulate s_dirt directly Artem Bityutskiy
2009-06-05 13:05 ` [PATCH v2.1 03/17] BFS: " Artem Bityutskiy
2009-06-05 13:05 ` [PATCH v2.1 04/17] EXOFS: " Artem Bityutskiy
2009-06-05 13:05 ` [PATCH v2.1 05/17] EXT2: " Artem Bityutskiy
2009-06-05 13:05 ` [PATCH v2.1 06/17] EXT4: " Artem Bityutskiy
2009-06-05 13:05 ` [PATCH v2.1 07/17] FAT: " Artem Bityutskiy
2009-06-05 13:05 ` [PATCH v2.1 08/17] HFS: " Artem Bityutskiy
2009-06-05 13:05 ` [PATCH v2.1 09/17] HFSPLUS: " Artem Bityutskiy
2009-06-05 13:05 ` [PATCH v2.1 10/17] JFFS2: " Artem Bityutskiy
2009-06-06  7:25   ` David Woodhouse
2009-06-07  9:21     ` Artem Bityutskiy
2009-06-05 13:05 ` [PATCH v2.1 11/17] NILFS: " Artem Bityutskiy
2009-06-05 12:04   ` Ryusuke Konishi
2009-06-05 13:05 ` [PATCH v2.1 12/17] reiserfs: " Artem Bityutskiy
2009-06-05 13:05 ` [PATCH v2.1 13/17] SYSV: " Artem Bityutskiy
2009-06-05 13:05 ` [PATCH v2.1 14/17] UDF: " Artem Bityutskiy
2009-06-05 13:05 ` [PATCH v2.1 15/17] UFS: " Artem Bityutskiy
2009-06-05 13:05 ` [PATCH v2.1 16/17] XFS: " Artem Bityutskiy
2009-06-05 13:05 ` Artem Bityutskiy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1244207155-2092-18-git-send-email-dedekind@infradead.org \
    --to=dedekind@infradead.org \
    --cc=Artem.Bityutskiy@nokia.com \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).