From: Jens Axboe <jens.axboe@oracle.com>
To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Cc: chris.mason@oracle.com, david@fromorbit.com, hch@infradead.org,
akpm@linux-foundation.org, jack@suse.cz,
yanmin_zhang@linux.intel.com, richard@rsk.demon.co.uk,
damien.wyart@free.fr, fweisbec@gmail.com, Alan.Brunelle@hp.com,
Jens Axboe <jens.axboe@oracle.com>
Subject: [PATCH 10/10] writeback: use spin_trylock() in bdi_writeback_all() for WB_SYNC_NONE
Date: Wed, 17 Jun 2009 13:07:22 +0200 [thread overview]
Message-ID: <1245236842-3141-11-git-send-email-jens.axboe@oracle.com> (raw)
In-Reply-To: <1245236842-3141-1-git-send-email-jens.axboe@oracle.com>
Not sure whether this is a good idea, hence it's at the back of the
series as a separate patch. In theory it should be fine, since all
WB_SYNC_NONE writeback is best-effort. No guarentees are made.
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
---
fs/fs-writeback.c | 13 +++++++++++--
1 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index de5f7ef..d589db3 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -506,9 +506,17 @@ void bdi_writeback_all(struct super_block *sb, struct writeback_control *wbc)
struct bdi_work *work;
LIST_HEAD(list);
-restart:
- spin_lock(&bdi_lock);
+ /*
+ * If this isn't a data integrity writeback, just drop it if
+ * someone is already holding the bdi_lock
+ */
+ if (!spin_trylock(&bdi_lock)) {
+ if (!must_wait)
+ return;
+ spin_lock(&bdi_lock);
+ }
+restart:
list_for_each_entry(bdi, &bdi_list, bdi_list) {
struct bdi_work *work;
@@ -535,6 +543,7 @@ restart:
__wbc = *wbc;
__wbc.bdi = bdi;
generic_sync_bdi_inodes(sb, &__wbc);
+ spin_lock(&bdi_lock);
goto restart;
}
if (must_wait)
--
1.6.3.rc0.1.gf800
next prev parent reply other threads:[~2009-06-17 11:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 11:07 [PATCH 0/10] Per-bdi writeback flusher threads v11 Jens Axboe
2009-06-17 11:07 ` [PATCH 01/10] writeback: move dirty inodes from super_block to backing_dev_info Jens Axboe
2009-06-17 11:07 ` [PATCH 02/10] writeback: switch to per-bdi threads for flushing data Jens Axboe
2009-06-17 11:07 ` [PATCH 03/10] writeback: get rid of pdflush completely Jens Axboe
2009-06-17 11:07 ` [PATCH 04/10] writeback: separate the flushing state/task from the bdi Jens Axboe
2009-06-17 11:07 ` [PATCH 05/10] writeback: support > 1 flusher thread per bdi Jens Axboe
2009-06-17 11:07 ` [PATCH 06/10] writeback: allow sleepy exit of default writeback task Jens Axboe
2009-06-17 11:07 ` [PATCH 07/10] writeback: add some debug inode list counters to bdi stats Jens Axboe
2009-06-17 11:07 ` [PATCH 08/10] writeback: add name to backing_dev_info Jens Axboe
2009-06-17 11:07 ` [PATCH 09/10] writeback: check for registered bdi in flusher add and inode dirty Jens Axboe
2009-06-17 11:07 ` Jens Axboe [this message]
2009-06-17 12:18 ` 2.6.30 backport (Was "Re: [PATCH 0/10] Per-bdi writeback flusher threads v11") Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2009-06-25 10:41 [PATCH 0/10] Per-bdi writeback flusher threads v12 Jens Axboe
2009-06-25 10:42 ` [PATCH 10/10] writeback: use spin_trylock() in bdi_writeback_all() for WB_SYNC_NONE Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245236842-3141-11-git-send-email-jens.axboe@oracle.com \
--to=jens.axboe@oracle.com \
--cc=Alan.Brunelle@hp.com \
--cc=akpm@linux-foundation.org \
--cc=chris.mason@oracle.com \
--cc=damien.wyart@free.fr \
--cc=david@fromorbit.com \
--cc=fweisbec@gmail.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@rsk.demon.co.uk \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).