From: Boaz Harrosh <bharrosh@panasas.com>
To: Jeff Garzik <jeff@garzik.org>, open-osd <osd-dev@open-osd.org>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH 6/6] osdblk: Adjust queue limits to lower device's limits
Date: Wed, 17 Jun 2009 19:07:52 +0300 [thread overview]
Message-ID: <1245254872-8717-1-git-send-email-bharrosh@panasas.com> (raw)
In-Reply-To: <4A391373.3050301@panasas.com>
call blk_queue_stack_limits() to copy queue limits from
the underline osd scsi_device. This is absolutely needed
because osdblk cannot sleep when allocating a lower-request and
therefore cannot be bouncing.
TODO: Dynamic changes of limits to the lower device queue
will not reflect in the upper driver
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
---
drivers/block/osdblk.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/block/osdblk.c b/drivers/block/osdblk.c
index e829360..b07e154 100644
--- a/drivers/block/osdblk.c
+++ b/drivers/block/osdblk.c
@@ -66,6 +66,7 @@
#include <scsi/osd_initiator.h>
#include <scsi/osd_attributes.h>
#include <scsi/osd_sec.h>
+#include <scsi/scsi_device.h>
#define DRV_NAME "osdblk"
#define PFX DRV_NAME ": "
@@ -410,6 +411,12 @@ static int osdblk_init_disk(struct osdblk_device *osdev)
return rc;
}
+ /* Set our limits to the lower device limits, because osdblk cannot
+ * sleep when allocating a lower-request and therefore cannot be
+ * bouncing.
+ */
+ blk_queue_stack_limits(q, osd_request_queue(osdev->osd));
+
blk_queue_prep_rq(q, blk_queue_start_tag);
blk_queue_ordered(q, QUEUE_ORDERED_DRAIN_FLUSH, osdblk_prepare_flush);
--
1.6.2.1
next prev parent reply other threads:[~2009-06-17 16:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 16:01 [PATCHSET 0/6] exofs: few patches for Linux 2.6.31 Boaz Harrosh
2009-06-17 16:03 ` [PATCH 1/6] exofs: Fix bio leak in error handling path (sync read) Boaz Harrosh
2009-06-17 16:04 ` [PATCH 2/6] exofs: Remove IBM copyrights Boaz Harrosh
2009-06-17 16:05 ` [PATCH 3/6] exofs: Avoid using file_fsync() Boaz Harrosh
2009-06-17 16:06 ` [PATCH 4/6] MAINTAINERS: Add osd maintained files (F:) Boaz Harrosh
2009-06-17 16:07 ` [PATCH 5/6] osdblk: a Linux block device for OSD objects Boaz Harrosh
2009-06-17 16:07 ` Boaz Harrosh [this message]
2009-06-18 12:46 ` [osd-dev] [PATCHSET 0/6] exofs: few patches for Linux 2.6.31 Boaz Harrosh
2009-06-18 12:55 ` [PATCH] open-osd: osdblk User Mode utility Boaz Harrosh
2009-06-22 12:15 ` [osd-dev] " Boaz Harrosh
2009-06-18 15:31 ` [osd-dev] [PATCHSET 0/6] exofs: few patches for Linux 2.6.31 Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245254872-8717-1-git-send-email-bharrosh@panasas.com \
--to=bharrosh@panasas.com \
--cc=jeff@garzik.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=osd-dev@open-osd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).