From: Jens Axboe <jens.axboe@oracle.com>
To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Cc: chris.mason@oracle.com, david@fromorbit.com, hch@infradead.org,
akpm@linux-foundation.org, jack@suse.cz,
yanmin_zhang@linux.intel.com, richard@rsk.demon.co.uk,
damien.wyart@free.fr, fweisbec@gmail.com, Alan.Brunelle@hp.com,
Jens Axboe <jens.axboe@oracle.com>
Subject: [PATCH 07/10] writeback: add some debug inode list counters to bdi stats
Date: Thu, 25 Jun 2009 12:42:00 +0200 [thread overview]
Message-ID: <1245926523-21959-8-git-send-email-jens.axboe@oracle.com> (raw)
In-Reply-To: <1245926523-21959-1-git-send-email-jens.axboe@oracle.com>
Add some debug entries to be able to inspect the internal state of
the writeback details.
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
---
mm/backing-dev.c | 38 ++++++++++++++++++++++++++++++++++----
1 files changed, 34 insertions(+), 4 deletions(-)
diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index 847665c..5305898 100644
--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -52,9 +52,29 @@ static void bdi_debug_init(void)
static int bdi_debug_stats_show(struct seq_file *m, void *v)
{
struct backing_dev_info *bdi = m->private;
+ struct bdi_writeback *wb;
unsigned long background_thresh;
unsigned long dirty_thresh;
unsigned long bdi_thresh;
+ unsigned long nr_dirty, nr_io, nr_more_io, nr_wb;
+ struct inode *inode;
+
+ /*
+ * inode lock is enough here, the bdi->wb_list is protected by
+ * RCU on the reader side
+ */
+ nr_wb = nr_dirty = nr_io = nr_more_io = 0;
+ spin_lock(&inode_lock);
+ list_for_each_entry(wb, &bdi->wb_list, list) {
+ nr_wb++;
+ list_for_each_entry(inode, &wb->b_dirty, i_list)
+ nr_dirty++;
+ list_for_each_entry(inode, &wb->b_io, i_list)
+ nr_io++;
+ list_for_each_entry(inode, &wb->b_more_io, i_list)
+ nr_more_io++;
+ }
+ spin_unlock(&inode_lock);
get_dirty_limits(&background_thresh, &dirty_thresh, &bdi_thresh, bdi);
@@ -64,12 +84,22 @@ static int bdi_debug_stats_show(struct seq_file *m, void *v)
"BdiReclaimable: %8lu kB\n"
"BdiDirtyThresh: %8lu kB\n"
"DirtyThresh: %8lu kB\n"
- "BackgroundThresh: %8lu kB\n",
+ "BackgroundThresh: %8lu kB\n"
+ "WriteBack threads:%8lu\n"
+ "b_dirty: %8lu\n"
+ "b_io: %8lu\n"
+ "b_more_io: %8lu\n"
+ "bdi_list: %8u\n"
+ "state: %8lx\n"
+ "wb_mask: %8lx\n"
+ "wb_list: %8u\n"
+ "wb_cnt: %8u\n",
(unsigned long) K(bdi_stat(bdi, BDI_WRITEBACK)),
(unsigned long) K(bdi_stat(bdi, BDI_RECLAIMABLE)),
- K(bdi_thresh),
- K(dirty_thresh),
- K(background_thresh));
+ K(bdi_thresh), K(dirty_thresh),
+ K(background_thresh), nr_wb, nr_dirty, nr_io, nr_more_io,
+ !list_empty(&bdi->bdi_list), bdi->state, bdi->wb_mask,
+ !list_empty(&bdi->wb_list), bdi->wb_cnt);
#undef K
return 0;
--
1.6.3.rc0.1.gf800
next prev parent reply other threads:[~2009-06-25 10:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-25 10:41 [PATCH 0/10] Per-bdi writeback flusher threads v12 Jens Axboe
2009-06-25 10:41 ` [PATCH 01/10] writeback: move dirty inodes from super_block to backing_dev_info Jens Axboe
2009-06-25 10:41 ` [PATCH 02/10] writeback: switch to per-bdi threads for flushing data Jens Axboe
2009-07-06 12:55 ` Artem Bityutskiy
2009-07-06 13:13 ` Jens Axboe
2009-07-06 13:26 ` Artem Bityutskiy
2009-07-07 15:27 ` Artem Bityutskiy
2009-07-08 0:57 ` Zhang, Yanmin
2009-07-08 4:47 ` Artem Bityutskiy
2009-06-25 10:41 ` [PATCH 03/10] writeback: get rid of pdflush completely Jens Axboe
2009-06-25 10:41 ` [PATCH 04/10] writeback: separate the flushing state/task from the bdi Jens Axboe
2009-06-25 10:41 ` [PATCH 05/10] writeback: support > 1 flusher thread per bdi Jens Axboe
2009-07-06 12:18 ` Artem Bityutskiy
2009-07-06 12:22 ` Jens Axboe
2009-07-06 13:37 ` Artem Bityutskiy
2009-07-06 13:49 ` Jamie Lokier
2009-07-06 14:11 ` Artem Bityutskiy
2009-07-06 15:43 ` Jens Axboe
2009-06-25 10:41 ` [PATCH 06/10] writeback: allow sleepy exit of default writeback task Jens Axboe
2009-06-25 10:42 ` Jens Axboe [this message]
2009-06-25 10:42 ` [PATCH 08/10] writeback: add name to backing_dev_info Jens Axboe
2009-06-25 10:42 ` [PATCH 09/10] writeback: check for registered bdi in flusher add and inode dirty Jens Axboe
2009-06-25 10:42 ` [PATCH 10/10] writeback: use spin_trylock() in bdi_writeback_all() for WB_SYNC_NONE Jens Axboe
2009-06-29 8:43 ` [PATCH 0/10] Per-bdi writeback flusher threads v12 Zhang, Yanmin
-- strict thread matches above, loose matches on Subject: below --
2009-08-31 12:14 [PATCH 0/10] Per-bdi writeback flusher threads v14 Jens Axboe
2009-08-31 12:14 ` [PATCH 07/10] writeback: add some debug inode list counters to bdi stats Jens Axboe
2009-06-17 11:07 [PATCH 0/10] Per-bdi writeback flusher threads v11 Jens Axboe
2009-06-17 11:07 ` [PATCH 07/10] writeback: add some debug inode list counters to bdi stats Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245926523-21959-8-git-send-email-jens.axboe@oracle.com \
--to=jens.axboe@oracle.com \
--cc=Alan.Brunelle@hp.com \
--cc=akpm@linux-foundation.org \
--cc=chris.mason@oracle.com \
--cc=damien.wyart@free.fr \
--cc=david@fromorbit.com \
--cc=fweisbec@gmail.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@rsk.demon.co.uk \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).