From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?J=F6rg?= Schummer Subject: Re: [PATCH take 2][RFC] fat: Save FAT root directory timestamps to volume label Date: Tue, 04 Aug 2009 11:42:37 +0300 Message-ID: <1249375357.5736.53.camel@jorg-desktop> References: <1248274841-3586-1-git-send-email-ext-jorg.2.schummer@nokia.com> <1248428635-26073-1-git-send-email-ext-jorg.2.schummer@nokia.com> <87fxclmhxy.fsf@devron.myhome.or.jp> <1248691635.4618.43.camel@jorg-desktop> <87ljmas5ym.fsf@devron.myhome.or.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" To: ext OGAWA Hirofumi Return-path: In-Reply-To: <87ljmas5ym.fsf@devron.myhome.or.jp> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, 2009-07-27 at 13:47 +0200, ext OGAWA Hirofumi wrote: > J=C3=B6rg Schummer writes: > BTW, the patch has several bugs. fat_get_label_entry() doesn't check > IS_FREE(), is it right? fat_create_label_entry() doesn't initialize a= ll > timestamp in the case of msdos. spin_lock() usage is wrong. and more.= =2E. After reviewing the patch again, I did notice some additional problems (I suppose that was the "and more..."). If and when I have time again, = I might take a closer look at it again. Thanks for your help until now! J=C3=B6rg