From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"mm-commits@vger.kernel.org" <mm-commits@vger.kernel.org>,
"richard@rsk.demon.co.uk" <richard@rsk.demon.co.uk>,
"chris.mason@oracle.com" <chris.mason@oracle.com>,
"jens.axboe@oracle.com" <jens.axboe@oracle.com>,
"mbligh@mbligh.org" <mbligh@mbligh.org>,
"miklos@szeredi.hu" <miklos@szeredi.hu>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: + mm-balance_dirty_pages-reduce-calls-to-global_page_state-to-reduce-c ache-references.patch added to -mm tree
Date: Sun, 23 Aug 2009 09:45:24 +0200 [thread overview]
Message-ID: <1251013524.7538.105.camel@twins> (raw)
In-Reply-To: <20090823072705.GA4028@localhost>
On Sun, 2009-08-23 at 15:27 +0800, Wu Fengguang wrote:
> On Sun, Aug 23, 2009 at 01:31:17PM +0800, Peter Zijlstra wrote:
> > On Sun, 2009-08-23 at 09:32 +0800, Wu Fengguang wrote:
> > > > > I'd propose to remove the above 'if' and liberate the following three 'if's.
> > > >
> > > > That might work, but it looses the total dirty_thresh constraint. The
> > > > sum of per-bdi dirties _should_ not be larger than that, but I'm not
> > > > sure it won't ever be.
> > > >
> > > > The clip code Richard removed ensured that, and I think I wrote that out
> > > > of more than sheer paranoia, but I'm not sure anymore :/
> > >
> > > Oh I assumed that your per-bdi throttling is not too permissive to
> > > exceed the global dirty_thresh. In theory the per-bdi throttling
> > > should be able to quickly stop the growing of (nr_reclaimable +
> > > nr_writeback). Once dirty_thresh is reached we already los
> >
> > Right, so:
> >
> > bdi_thresh_n = dirty_thresh * p(n) + eps.
> >
> > and
> >
> > \Sum_n p(n) = 1
> >
> > So:
> >
> > \Sum_n bdi_thresh_n = dirty_thresh + n*eps
> >
> > Which yields an O(n) error bound.
> >
> > I'm just not sure how large the thing is in reality, and paranoia won
> > out.
>
> A wild question: is it possible to make the equation:
>
> bdi_thresh_n = dirty_thresh * p(n) - eps.
Possibly, I'd have to go over the math to get a proper equation for eps,
then see what needs to be done to get avg(eps) <= 0.
next prev parent reply other threads:[~2009-08-23 7:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200908212250.n7LMox3g029154@imap1.linux-foundation.org>
2009-08-22 2:51 ` + mm-balance_dirty_pages-reduce-calls-to-global_page_state-to-reduce-c ache-references.patch added to -mm tree Wu Fengguang
2009-08-22 18:11 ` Peter Zijlstra
2009-08-23 1:32 ` Wu Fengguang
2009-08-23 5:31 ` Peter Zijlstra
2009-08-23 7:27 ` Wu Fengguang
2009-08-23 7:45 ` Peter Zijlstra [this message]
2009-09-02 8:31 ` Peter Zijlstra
2009-09-02 9:57 ` Wu Fengguang
2009-09-02 10:45 ` Peter Zijlstra
2009-09-02 13:53 ` Richard Kennedy
2009-09-03 2:22 ` Wu Fengguang
2009-09-03 3:09 ` Wu Fengguang
2009-09-03 9:48 ` Richard Kennedy
2009-09-03 11:05 ` Wu Fengguang
2009-09-03 12:26 ` Richard Kennedy
2009-09-03 4:53 ` Wu Fengguang
2009-08-23 9:33 ` Richard Kennedy
2009-08-23 13:00 ` Wu Fengguang
2009-08-23 13:46 ` Richard Kennedy
2009-08-24 1:41 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251013524.7538.105.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=chris.mason@oracle.com \
--cc=fengguang.wu@intel.com \
--cc=jens.axboe@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mbligh@mbligh.org \
--cc=miklos@szeredi.hu \
--cc=mm-commits@vger.kernel.org \
--cc=richard@rsk.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).