From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Walker Subject: Re: [patch 16/33] fs: dcache per-bucket dcache hash locking Date: Fri, 04 Sep 2009 07:51:37 -0700 Message-ID: <1252075897.22928.23.camel@desktop> References: <20090904065142.114706411@nick.local0.net> <20090904065536.424606052@nick.local0.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: npiggin@suse.de Return-path: Received: from fifo99.com ([67.223.236.141]:52688 "EHLO fifo99.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932351AbZIDOvb (ORCPT ); Fri, 4 Sep 2009 10:51:31 -0400 In-Reply-To: <20090904065536.424606052@nick.local0.net> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, 2009-09-04 at 16:51 +1000, npiggin@suse.de wrote: > +/* This should be called _only_ with a lock pinning the dentry */ > +static inline struct dentry * __dget_locked_dlock(struct dentry > *dentry) > +{ > + dentry->d_count++; > + dentry_lru_del_init(dentry); > + return dentry; > +} > + > +static inline struct dentry * __dget_locked(struct dentry *dentry) > +{ Could you run your series through checkpatch, and clean up at least any errors you find.. Plus add your signed off, most (all?) aren't signed off.. Daniel