From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: Re: [patch 01/11] fs: new truncate helpers Date: Mon, 07 Sep 2009 10:48:21 +0300 Message-ID: <1252309701.5060.17.camel@localhost> References: <20090820163504.131529718@suse.de> <20090820164050.401703779@suse.de> <4A94E663.90705@gmail.com> <20090907073330.GD1875@wotan.suse.de> Reply-To: dedekind1@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Andrew Morton , linux-fsdevel@vger.kernel.org, Christoph Hellwig To: Nick Piggin Return-path: Received: from smtp.nokia.com ([192.100.105.134]:53510 "EHLO mgw-mx09.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751842AbZIGHth (ORCPT ); Mon, 7 Sep 2009 03:49:37 -0400 In-Reply-To: <20090907073330.GD1875@wotan.suse.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, 2009-09-07 at 09:33 +0200, Nick Piggin wrote: > > >+int inode_newsize_ok(struct inode *inode, loff_t offset) > > >+{ > >=20 > > Could you use 'const' for inode here? >=20 > Sorry, I don't think I replied to you. Thanks for the suggestions, ye= s > const wouldn't hurt I guess. I will be sending a couple of incrementa= l > updates to Andrew shortly so I'll include that. Thanks. I have done 'new_truncate' modifications for UBIFS and got gcc warnings because my calling functions use 'const'. --=20 Best Regards, Artem Bityutskiy (=D0=90=D1=80=D1=82=D1=91=D0=BC =D0=91=D0=B8=D1=82=D1=8E= =D1=86=D0=BA=D0=B8=D0=B9) -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html