From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?J=F6rg?= Schummer Subject: [PATCH take 3][RFC] fat: Save FAT root directory timestamps to volume label Date: Tue, 08 Sep 2009 17:28:51 +0300 Message-ID: <1252420131.5782.2.camel@jorg-desktop> References: <1248274841-3586-1-git-send-email-ext-jorg.2.schummer@nokia.com> <1248428635-26073-1-git-send-email-ext-jorg.2.schummer@nokia.com> <87fxclmhxy.fsf@devron.myhome.or.jp> <1248691635.4618.43.camel@jorg-desktop> <87ljmas5ym.fsf@devron.myhome.or.jp> <1249375357.5736.53.camel@jorg-desktop> <87zlafswci.fsf@devron.myhome.or.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: hirofumi@mail.parknet.co.jp Return-path: Received: from smtp.nokia.com ([192.100.105.134]:52629 "EHLO mgw-mx09.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750719AbZIHO3S (ORCPT ); Tue, 8 Sep 2009 10:29:18 -0400 In-Reply-To: <87zlafswci.fsf@devron.myhome.or.jp> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, 2009-08-04 at 12:32 +0200, ext OGAWA Hirofumi wrote:=20 > J=C3=B6rg Schummer writes: >=20 > > On Mon, 2009-07-27 at 13:47 +0200, ext OGAWA Hirofumi wrote: > >> J=C3=B6rg Schummer writes: > > > >> BTW, the patch has several bugs. fat_get_label_entry() doesn't che= ck > >> IS_FREE(), is it right? fat_create_label_entry() doesn't initializ= e all > >> timestamp in the case of msdos. spin_lock() usage is wrong. and mo= re... > > > > After reviewing the patch again, I did notice some additional probl= ems > > (I suppose that was the "and more..."). If and when I have time aga= in, I > > might take a closer look at it again. > > > > Thanks for your help until now! Hello, on the off-chance that somebody would like to use this mechanism, I did a 3rd take of the patch. I tried to fix the problems of the previous patch and additionally added the functionality to correct the root dir timestamp's mtime and atime somewhat based on contained directory entries' ctime. Any comments are welcome, but especially I'd like to ask if it is safe = / good / doable to call=20 remove_inode_hash(inode); fat_attach(inode, i_pos); insert_inode_hash(inode); inside fat_write_inode . Thanks for any feedback! J=C3=B6rg -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html