From: James Bottomley <James.Bottomley@suse.de>
To: Russell King <rmk@arm.linux.org.uk>
Cc: Parisc List <linux-parisc@vger.kernel.org>,
Linux Filesystem Mailing List <linux-fsdevel@vger.kernel.org>,
linux-arch@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: [PATCH 5/5] xfs: fix xfs to work with Virtually Indexed architectures
Date: Wed, 09 Sep 2009 03:21:58 +0000 [thread overview]
Message-ID: <1252466518.13003.373.camel@mulgrave.site> (raw)
In-Reply-To: <1252466070.13003.365.camel@mulgrave.site>
xfs_buf.c includes what is essentially a hand rolled version of
blk_rq_map_kern(). In order to work properly with the vmalloc buffers
that xfs uses, this hand rolled routine must also implement the flushing
API for vmap/vmalloc areas.
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
---
fs/xfs/linux-2.6/xfs_buf.c | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/fs/xfs/linux-2.6/xfs_buf.c b/fs/xfs/linux-2.6/xfs_buf.c
index 965df12..62ae977 100644
--- a/fs/xfs/linux-2.6/xfs_buf.c
+++ b/fs/xfs/linux-2.6/xfs_buf.c
@@ -1138,6 +1138,10 @@ xfs_buf_bio_end_io(
do {
struct page *page = bvec->bv_page;
+ if (is_vmalloc_addr(bp->b_addr))
+ invalidate_kernel_dcache_addr(bp->b_addr +
+ bvec->bv_offset);
+
ASSERT(!PagePrivate(page));
if (unlikely(bp->b_error)) {
if (bp->b_flags & XBF_READ)
@@ -1202,6 +1206,9 @@ _xfs_buf_ioapply(
bio->bi_end_io = xfs_buf_bio_end_io;
bio->bi_private = bp;
+ if (is_vmalloc_addr(bp->b_addr))
+ flush_kernel_dcache_addr(bp->b_addr);
+
bio_add_page(bio, bp->b_pages[0], PAGE_CACHE_SIZE, 0);
size = 0;
@@ -1228,6 +1235,9 @@ next_chunk:
if (nbytes > size)
nbytes = size;
+ if (is_vmalloc_addr(bp->b_addr))
+ flush_kernel_dcache_addr(bp->b_addr + PAGE_SIZE*map_i);
+
rbytes = bio_add_page(bio, bp->b_pages[map_i], nbytes, offset);
if (rbytes < nbytes)
break;
--
1.6.3.3
next prev parent reply other threads:[~2009-09-09 3:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-08 18:27 xfs failure on parisc (and presumably other VI cache systems) caused by I/O to vmalloc/vmap areas James Bottomley
2009-09-08 19:00 ` Russell King
2009-09-08 19:11 ` James Bottomley
2009-09-08 20:16 ` Russell King
2009-09-08 20:39 ` James Bottomley
2009-09-08 21:39 ` Russell King
2009-09-09 3:14 ` James Bottomley
2009-09-09 3:17 ` [PATCH 1/5] mm: add coherence API for DMA " James Bottomley
2009-09-09 3:23 ` James Bottomley
2009-09-09 3:35 ` Paul Mundt
2009-09-09 14:34 ` James Bottomley
2009-09-10 0:24 ` Paul Mundt
2009-09-10 0:30 ` James Bottomley
2009-09-09 3:18 ` [PATCH 2/5] parisc: add mm " James Bottomley
2009-09-09 3:20 ` [PATCH 3/5] arm: " James Bottomley
2009-09-09 3:21 ` [PATCH 4/5] block: permit I/O to vmalloc/vmap kernel pages James Bottomley
2009-09-09 3:21 ` James Bottomley [this message]
2009-10-13 1:40 ` xfs failure on parisc (and presumably other VI cache systems) caused by I/O to vmalloc/vmap areas Christoph Hellwig
2009-10-13 4:13 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252466518.13003.373.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=hch@lst.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).