From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Paul Mundt <lethal@linux-sh.org>
Cc: Russell King <rmk@arm.linux.org.uk>,
Parisc List <linux-parisc@vger.kernel.org>,
Linux Filesystem Mailing List <linux-fsdevel@vger.kernel.org>,
linux-arch@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 1/5] mm: add coherence API for DMA to vmalloc/vmap areas
Date: Wed, 09 Sep 2009 09:34:38 -0500 [thread overview]
Message-ID: <1252506878.3918.32.camel@mulgrave.site> (raw)
In-Reply-To: <20090909033532.GD23049@linux-sh.org>
On Wed, 2009-09-09 at 12:35 +0900, Paul Mundt wrote:
> And here I thought it was a new gcc construct along the lines of
> inline-if-so-inclined.. :-)
Actually, I missed the fact that sh also sets
ARCH_HAS_FLUSH_KERNEL_DCACHE_PAGE, so you'll need implementations of
these functions too. Does this look right?
James
---
diff --git a/arch/sh/include/asm/cacheflush.h b/arch/sh/include/asm/cacheflush.h
index 4c5462d..db06611 100644
--- a/arch/sh/include/asm/cacheflush.h
+++ b/arch/sh/include/asm/cacheflush.h
@@ -48,6 +48,14 @@ static inline void flush_kernel_dcache_page(struct page *page)
{
flush_dcache_page(page);
}
+static inline void flush_kernel_dcache_addr(void *addr)
+{
+ __flush_invalidate_region(addr, PAGE_SIZE);
+}
+static inline void invalidate_kernel_dcache_addr(void *addr)
+{
+ __flush_invalidate_region(addr, PAGE_SIZE);
+}
#if defined(CONFIG_CPU_SH4) && !defined(CONFIG_CACHE_OFF)
extern void copy_to_user_page(struct vm_area_struct *vma,
next prev parent reply other threads:[~2009-09-09 14:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-08 18:27 xfs failure on parisc (and presumably other VI cache systems) caused by I/O to vmalloc/vmap areas James Bottomley
2009-09-08 19:00 ` Russell King
2009-09-08 19:11 ` James Bottomley
2009-09-08 20:16 ` Russell King
2009-09-08 20:39 ` James Bottomley
2009-09-08 21:39 ` Russell King
2009-09-09 3:14 ` James Bottomley
2009-09-09 3:17 ` [PATCH 1/5] mm: add coherence API for DMA " James Bottomley
2009-09-09 3:23 ` James Bottomley
2009-09-09 3:35 ` Paul Mundt
2009-09-09 14:34 ` James Bottomley [this message]
2009-09-10 0:24 ` Paul Mundt
2009-09-10 0:30 ` James Bottomley
2009-09-09 3:18 ` [PATCH 2/5] parisc: add mm " James Bottomley
2009-09-09 3:20 ` [PATCH 3/5] arm: " James Bottomley
2009-09-09 3:21 ` [PATCH 4/5] block: permit I/O to vmalloc/vmap kernel pages James Bottomley
2009-09-09 3:21 ` [PATCH 5/5] xfs: fix xfs to work with Virtually Indexed architectures James Bottomley
2009-10-13 1:40 ` xfs failure on parisc (and presumably other VI cache systems) caused by I/O to vmalloc/vmap areas Christoph Hellwig
2009-10-13 4:13 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252506878.3918.32.camel@mulgrave.site \
--to=james.bottomley@hansenpartnership.com \
--cc=hch@lst.de \
--cc=lethal@linux-sh.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).