linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@suse.de>
To: linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-parisc@vger.kernel.org
Cc: Russell King <rmk@arm.linux.org.uk>,
	Christoph Hellwig <hch@lst.de>, Paul Mundt <lethal@linux-sh.org>,
	James Bottomley <James.Bottomley@suse.de>
Subject: [PATCH 6/6] xfs: fix xfs to work with Virtually Indexed architectures
Date: Wed,  9 Sep 2009 10:52:16 -0500	[thread overview]
Message-ID: <1252511536-22066-7-git-send-email-James.Bottomley@suse.de> (raw)
In-Reply-To: <1252511536-22066-6-git-send-email-James.Bottomley@suse.de>

xfs_buf.c includes what is essentially a hand rolled version of
blk_rq_map_kern().  In order to work properly with the vmalloc buffers
that xfs uses, this hand rolled routine must also implement the flushing
API for vmap/vmalloc areas.

Signed-off-by: James Bottomley <James.Bottomley@suse.de>
---
 fs/xfs/linux-2.6/xfs_buf.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/fs/xfs/linux-2.6/xfs_buf.c b/fs/xfs/linux-2.6/xfs_buf.c
index 965df12..62ae977 100644
--- a/fs/xfs/linux-2.6/xfs_buf.c
+++ b/fs/xfs/linux-2.6/xfs_buf.c
@@ -1138,6 +1138,10 @@ xfs_buf_bio_end_io(
 	do {
 		struct page	*page = bvec->bv_page;
 
+		if (is_vmalloc_addr(bp->b_addr))
+			invalidate_kernel_dcache_addr(bp->b_addr +
+						      bvec->bv_offset);
+
 		ASSERT(!PagePrivate(page));
 		if (unlikely(bp->b_error)) {
 			if (bp->b_flags & XBF_READ)
@@ -1202,6 +1206,9 @@ _xfs_buf_ioapply(
 		bio->bi_end_io = xfs_buf_bio_end_io;
 		bio->bi_private = bp;
 
+		if (is_vmalloc_addr(bp->b_addr))
+			flush_kernel_dcache_addr(bp->b_addr);
+
 		bio_add_page(bio, bp->b_pages[0], PAGE_CACHE_SIZE, 0);
 		size = 0;
 
@@ -1228,6 +1235,9 @@ next_chunk:
 		if (nbytes > size)
 			nbytes = size;
 
+		if (is_vmalloc_addr(bp->b_addr))
+			flush_kernel_dcache_addr(bp->b_addr + PAGE_SIZE*map_i);
+
 		rbytes = bio_add_page(bio, bp->b_pages[map_i], nbytes, offset);
 		if (rbytes < nbytes)
 			break;
-- 
1.6.3.3

  reply	other threads:[~2009-09-09 15:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-09 15:52 [PATCH 0/6] fix xfs by making I/O to vmap/vmalloc areas work James Bottomley
2009-09-09 15:52 ` [PATCH 1/6] mm: add coherence API for DMA to vmalloc/vmap areas James Bottomley
2009-09-09 15:52   ` [PATCH 2/6] parisc: add mm " James Bottomley
2009-09-09 15:52     ` [PATCH 3/6] arm: " James Bottomley
2009-09-09 15:52       ` [PATCH 4/6] sh: " James Bottomley
2009-09-09 15:52         ` [PATCH 5/6] block: permit I/O to vmalloc/vmap kernel pages James Bottomley
2009-09-09 15:52           ` James Bottomley [this message]
2009-09-09 17:55             ` [PATCH 6/6] xfs: fix xfs to work with Virtually Indexed architectures Christoph Hellwig
2009-09-11 21:57             ` James Bottomley
2009-09-10  0:27         ` [PATCH 4/6] sh: add mm API for DMA to vmalloc/vmap areas Paul Mundt
2009-09-10  0:32           ` James Bottomley
2009-09-10  6:14 ` [PATCH 0/6] fix xfs by making I/O to vmap/vmalloc areas work Matt Fleming
2009-09-11 21:37   ` James Bottomley
  -- strict thread matches above, loose matches on Subject: below --
2009-09-17 23:06 James Bottomley
2009-09-17 23:06 ` [PATCH 1/6] mm: add coherence API for DMA to vmalloc/vmap areas James Bottomley
2009-09-17 23:06   ` [PATCH 2/6] parisc: add mm " James Bottomley
2009-09-17 23:06     ` [PATCH 3/6] arm: " James Bottomley
2009-09-17 23:06       ` [PATCH 4/6] sh: " James Bottomley
2009-09-17 23:07         ` [PATCH 5/6] block: permit I/O to vmalloc/vmap kernel pages James Bottomley
2009-09-17 23:07           ` [PATCH 6/6] xfs: fix xfs to work with Virtually Indexed architectures James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1252511536-22066-7-git-send-email-James.Bottomley@suse.de \
    --to=james.bottomley@suse.de \
    --cc=hch@lst.de \
    --cc=lethal@linux-sh.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).