From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicholas Miell Subject: Re: [PATCH] VFS: document what MAY_ACCESS means Date: Sun, 20 Sep 2009 18:52:01 -0700 Message-ID: <1253497921.30237.1.camel@entropy> References: <20090921012933.2631.85495.stgit@paris.rdu.redhat.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, hch@infradead.org To: Eric Paris Return-path: In-Reply-To: <20090921012933.2631.85495.stgit@paris.rdu.redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Since this is a documentation patch, here are some nits. > +/* > + * The vfs MAY_ACCESS flag really means that we might not use the object > + * immediately (consider chdir which might not actually use the new dir). > + * Thus permissions must be checked mmediately rather than relying on later ^ immediately > + * checks during the actual user of the object in question. This is an ^ use > + * internal flag and should not come from userspace. > + */ > #define MAY_ACCESS 16 > #define MAY_OPEN 32 -- Nicholas Miell