From: Miklos Szeredi <mszeredi@suse.cz>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
Valdis.Kletnieks@vt.edu, agruen@suse.de, hch@lst.de,
hugh.dickins@tiscali.co.uk, matthew@wil.cx
Subject: Re: [patch 18/21] vfs: seq_file: add helpers for data filling
Date: Mon, 21 Sep 2009 14:43:40 +0200 [thread overview]
Message-ID: <1253537020.27376.68.camel@tucsk> (raw)
In-Reply-To: <20090921100301.GI5858@ZenIV.linux.org.uk>
On Mon, 2009-09-21 at 11:03 +0100, Al Viro wrote:
> On Fri, Sep 18, 2009 at 01:06:00PM -0700, akpm@linux-foundation.org wrote:
> > From: Miklos Szeredi <mszeredi@suse.cz>
> >
> > Add two helpers that allow access to the seq_file's own buffer, but
> > hides the internal details of seq_files.
> >
> > This allows easier implementation of special purpose filling
> > functions. It also cleans up some existing functions which duplicated
> > the seq_file logic.
>
> Nice, but I suspect that exporting those two would be the right thing.
> That, or inlining them - we are not actually hiding anything here, seeing
> that struct seq_file is declared right there in the seq_file.h.
>
> I'm certainly fine with these helpers and associated cleanup. Unless
> somebody has realistic plans of actually hiding the seq_file implementation[1],
> I'd simply inline those two in seq_file.h. Miklos?
Updated patches coming up.
Thanks,
Miklos
prev parent reply other threads:[~2009-09-21 12:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-18 20:06 [patch 18/21] vfs: seq_file: add helpers for data filling akpm
2009-09-21 10:03 ` Al Viro
2009-09-21 12:43 ` Miklos Szeredi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253537020.27376.68.camel@tucsk \
--to=mszeredi@suse.cz \
--cc=Valdis.Kletnieks@vt.edu \
--cc=agruen@suse.de \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=hugh.dickins@tiscali.co.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).