From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Zijlstra <peterz@infradead.org>
Subject: Re: [patch 03/33] fs: scale files_lock
Date: Mon, 28 Sep 2009 15:22:19 +0200
Message-ID: <1254144139.15795.4.camel@laptop>
References: <20090904065142.114706411@nick.local0.net>
	 <20090904065534.303326352@nick.local0.net>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
To: npiggin@suse.de
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S1752986AbZI1NWR@vger.kernel.org>
In-Reply-To: <20090904065534.303326352@nick.local0.net>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Fri, 2009-09-04 at 16:51 +1000, npiggin@suse.de wrote:
> +static void file_list_lock_all(void)
> +{
> +       int i;
> +       int nr = 0;
> +
> +       for_each_possible_cpu(i) {
> +               spinlock_t *lock;
> +
> +               lock = &per_cpu(files_cpulock, i);
> +               spin_lock_nested(lock, nr);
> +               nr++;
> +       }
> +}

Same here, this'll make lockdep explode on >8-way. And create large spin
times on large smp boxen.