From: Jan Blunck <jblunck@suse.de>
To: linux-fsdevel@vger.kernel.org
Cc: Matthew Wilcox <matthew@wil.cx>,
linux-kernel@vger.kernel.org, Jan Blunck <jblunck@suse.de>,
William Irwin <wli@holomorphy.com>,
Andrew Morton <akpm@linux-foundation.org>,
James Morris <jmorris@namei.org>, Mel Gorman <mel@csn.ul.ie>,
David Howells <dhowells@redhat.com>,
Serge Hallyn <serue@us.ibm.com>
Subject: [PATCH 19/27] BKL: Remove BKL from hugetlbfs
Date: Mon, 2 Nov 2009 11:04:59 +0100 [thread overview]
Message-ID: <1257156307-24175-20-git-send-email-jblunck@suse.de> (raw)
In-Reply-To: <1257156307-24175-1-git-send-email-jblunck@suse.de>
BKL is only used in fill_super. It is safe to remove it.
Signed-off-by: Jan Blunck <jblunck@suse.de>
---
fs/hugetlbfs/inode.c | 12 ++----------
1 files changed, 2 insertions(+), 10 deletions(-)
diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
index 53be2b9..87a1258 100644
--- a/fs/hugetlbfs/inode.c
+++ b/fs/hugetlbfs/inode.c
@@ -32,7 +32,6 @@
#include <linux/security.h>
#include <linux/ima.h>
#include <linux/magic.h>
-#include <linux/smp_lock.h> /* Only for lock_kernel() */
#include <asm/uaccess.h>
@@ -825,7 +824,6 @@ hugetlbfs_fill_super(struct super_block *sb, void *data, int silent)
struct hugetlbfs_config config;
struct hugetlbfs_sb_info *sbinfo;
- lock_kernel();
save_mount_options(sb, data);
config.nr_blocks = -1; /* No limit on size by default */
@@ -835,16 +833,12 @@ hugetlbfs_fill_super(struct super_block *sb, void *data, int silent)
config.mode = 0755;
config.hstate = &default_hstate;
ret = hugetlbfs_parse_options(data, &config);
- if (ret) {
- unlock_kernel();
+ if (ret)
return ret;
- }
sbinfo = kmalloc(sizeof(struct hugetlbfs_sb_info), GFP_KERNEL);
- if (!sbinfo) {
- unlock_kernel();
+ if (!sbinfo)
return -ENOMEM;
- }
sb->s_fs_info = sbinfo;
sbinfo->hstate = config.hstate;
spin_lock_init(&sbinfo->stat_lock);
@@ -869,11 +863,9 @@ hugetlbfs_fill_super(struct super_block *sb, void *data, int silent)
goto out_free;
}
sb->s_root = root;
- unlock_kernel();
return 0;
out_free:
kfree(sbinfo);
- unlock_kernel();
return -ENOMEM;
}
--
1.6.4.2
next prev parent reply other threads:[~2009-11-02 10:07 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-02 10:04 [PATCH 00/27] Push down BKL to the filesystems (v2) Jan Blunck
2009-11-02 10:04 ` [PATCH 01/27] BKL: Push down BKL from do_new_mount() to the filesystems get_sb/fill_super operation Jan Blunck
2009-11-02 17:11 ` Jan Blunck
2009-11-03 10:12 ` Christoph Hellwig
2009-11-03 10:25 ` Jan Blunck
2009-11-03 14:33 ` Christoph Hellwig
2009-11-03 14:46 ` Arnd Bergmann
2009-11-02 10:04 ` [PATCH 02/27] BKL: Remove outdated comment and include Jan Blunck
2009-11-02 10:04 ` [PATCH 03/27] BKL: Remove BKL from simple_fill_super Jan Blunck
2009-11-02 10:04 ` [PATCH 04/27] ext2: Add ext2_sb_info mutex Jan Blunck
2009-11-02 10:26 ` Andi Kleen
2009-11-02 16:57 ` Jan Blunck
2009-11-02 17:25 ` Andi Kleen
2009-11-05 13:55 ` Jan Kara
2009-11-02 10:04 ` [PATCH 05/27] BKL: Remove BKL from ext2 filesystem Jan Blunck
2009-11-05 12:41 ` Jan Kara
2009-11-05 13:06 ` Jan Blunck
2009-11-05 13:56 ` Jan Kara
2009-11-02 10:04 ` [PATCH 06/27] BKL: Remove BKL from ext3 fill_super() Jan Blunck
2009-11-05 11:55 ` Jan Kara
2009-11-02 10:04 ` [PATCH 07/27] BKL: Remove BKL from ext3_put_super() and ext3_remount() Jan Blunck
2009-11-05 11:56 ` Jan Kara
2009-11-02 10:04 ` [PATCH 08/27] BKL: Remove BKL from ext4 filesystem Jan Blunck
2009-11-09 14:45 ` Theodore Tso
2009-11-02 10:04 ` [PATCH 09/27] BKL: Remove BKL from 9p Jan Blunck
2009-11-02 10:04 ` [PATCH 10/27] BKL: Remove BKL from autofs4 Jan Blunck
2009-11-02 11:13 ` Ian Kent
2009-11-02 10:04 ` [PATCH 11/27] BKL: Remove BKL from befs Jan Blunck
2009-11-02 10:04 ` [PATCH 12/27] BKL: Remove BKL from btrfs Jan Blunck
2009-11-02 12:13 ` Chris Mason
2009-11-02 10:04 ` [PATCH 13/27] BKL: Remove BKL from configfs Jan Blunck
2009-11-02 18:44 ` Joel Becker
2009-11-02 10:04 ` [PATCH 14/27] BKL: Remove BKL from cramfs Jan Blunck
2009-11-02 10:46 ` Coly Li
2009-11-02 10:04 ` [PATCH 15/27] BKL: Remove BKL from devpts Jan Blunck
2009-11-02 10:04 ` [PATCH 16/27] BKL: Remove BKL from efs Jan Blunck
2009-11-02 10:47 ` Coly Li
2009-11-02 10:04 ` [PATCH 17/27] BKL: Remove BKL from exofs Jan Blunck
2009-11-02 10:04 ` [PATCH 18/27] BKL: Remove BKL from hostfs Jan Blunck
2009-11-02 10:04 ` Jan Blunck [this message]
2009-11-02 10:05 ` [PATCH 20/27] BKL: Remove BKL from minix Jan Blunck
2009-11-02 10:46 ` Coly Li
2009-11-02 10:05 ` [PATCH 21/27] BKL: Remove BKL from omfs Jan Blunck
2009-11-03 19:21 ` Bob Copeland
2009-11-02 10:05 ` [PATCH 22/27] BKL: Remove BKL from openpromfs Jan Blunck
2009-11-02 10:05 ` [PATCH 23/27] BKL: Remove BKL from ramfs Jan Blunck
2009-11-02 10:05 ` [PATCH 24/27] BKL: Remove BKL from romfs Jan Blunck
2009-11-02 10:05 ` [PATCH 25/27] BKL: Remove BKL from sysfs Jan Blunck
2009-11-02 16:44 ` Greg KH
2009-11-02 17:35 ` Jan Blunck
2009-11-02 19:58 ` Greg KH
2009-11-02 10:05 ` [PATCH 26/27] BKL: Remove BKL from ubifs Jan Blunck
2009-11-03 5:47 ` Artem Bityutskiy
2009-11-02 10:05 ` [PATCH 27/27] BKL: Remove BKL from xfs Jan Blunck
2009-11-02 11:29 ` [PATCH 00/27] Push down BKL to the filesystems (v2) Christian Borntraeger
2009-11-02 13:30 ` Jan Blunck
2009-11-02 15:29 ` Christian Borntraeger
2009-11-02 15:31 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257156307-24175-20-git-send-email-jblunck@suse.de \
--to=jblunck@suse.de \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=jmorris@namei.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mel@csn.ul.ie \
--cc=serue@us.ibm.com \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).