From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Whitehouse Subject: Re: [PATCH 1/2] sanitize xattr handler prototypes Date: Tue, 03 Nov 2009 17:11:47 +0000 Message-ID: <1257268307.6052.764.camel@localhost.localdomain> References: <20091103154448.GB23101@lst.de> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: viro@zeniv.linux.org.uk, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from mx1.redhat.com ([209.132.183.28]:24097 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751864AbZKCRMR (ORCPT ); Tue, 3 Nov 2009 12:12:17 -0500 In-Reply-To: <20091103154448.GB23101@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi, On Tue, 2009-11-03 at 16:44 +0100, Christoph Hellwig wrote: > Add a flags argument to strcut xattr_handler and pass it to all xattr > handler methods. This allows using the same methods for multiple > handlers, e.g. for the ACL methods which perform exactly the same action > for the access and default ACLs, just using a different underlying > attribute. With a little more groundwork it'll also allow sharing the > methods for the regular user/trusted/secure handlers in extN, ocfs2 and > jffs2 like it's already done for xfs in this patch. > > Also change the inode argument to the handlers to a dentry to allow > using the handlers mechnism for filesystems that require it later, > e.g. cifs. > > Signed-off-by: Christoph Hellwig > Reviewed-by: James Morris > Acked-by: Joel Becker > GFS2 bits Acked-by: Steven Whitehouse Steve.