From: Kay Sievers <kay.sievers@vrfy.org>
To: linux-fsdevel <linux-fsdevel@vger.kernel.org>
Cc: Greg KH <greg@kroah.com>
Subject: get_sb_single() - do not pass options twice
Date: Thu, 05 Nov 2009 23:28:23 +0100 [thread overview]
Message-ID: <1257460103.2126.0.camel@yio.site> (raw)
From: Kay Sievers <kay.sievers@vrfy.org>
Subject: vfs: get_sb_single() - do not pass options twice
Filesystem code usually destroys the option buffer while
parsing it, which leads to errors when the same buffer is
passed twice. In case we fill a new superblock with the
options, do not pass the options again to the remount()
call.
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Kay Sievers <kay.sievers@vrfy.org>
---
fs/super.c | 2 ++
1 file changed, 2 insertions(+)
--- a/fs/super.c
+++ b/fs/super.c
@@ -900,6 +900,8 @@ int get_sb_single(struct file_system_typ
deactivate_locked_super(s);
return error;
}
+ /* options usually get mangled and can only be parsed once */
+ data = NULL;
s->s_flags |= MS_ACTIVE;
}
do_remount_sb(s, flags, data, 0);
next reply other threads:[~2009-11-05 22:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-05 22:28 Kay Sievers [this message]
2009-12-12 10:07 ` get_sb_single() - do not pass options twice Kay Sievers
2009-12-15 9:48 ` Miklos Szeredi
2009-12-15 14:39 ` Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257460103.2126.0.camel@yio.site \
--to=kay.sievers@vrfy.org \
--cc=greg@kroah.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).