From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Blunck Subject: [PATCH 02/20] AFFS: Free sbi memory in error path Date: Wed, 18 Nov 2009 10:24:35 +0100 Message-ID: <1258536293-7762-3-git-send-email-jblunck@suse.de> References: <1258536293-7762-1-git-send-email-jblunck@suse.de> Cc: Linux-Kernel Mailinglist , Andrew Morton , jkacur@redhat.com, Thomas Gleixner , Christoph Hellwig , Arnd Bergmann , matthew@wil.cx, Jan Blunck , Roman Zippel To: linux-fsdevel@vger.kernel.org Return-path: Received: from cantor2.suse.de ([195.135.220.15]:39377 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754541AbZKRJYy (ORCPT ); Wed, 18 Nov 2009 04:24:54 -0500 In-Reply-To: <1258536293-7762-1-git-send-email-jblunck@suse.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: I spotted the missing kfree() while removing the BKL. Signed-off-by: Jan Blunck --- fs/affs/super.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/affs/super.c b/fs/affs/super.c index 104fdcb..058c2c7 100644 --- a/fs/affs/super.c +++ b/fs/affs/super.c @@ -316,7 +316,7 @@ static int affs_fill_super(struct super_block *sb, void *data, int silent) &blocksize,&sbi->s_prefix, sbi->s_volume, &mount_flags)) { printk(KERN_ERR "AFFS: Error parsing options\n"); - return -EINVAL; + goto out_error_free_sbi; } /* N.B. after this point s_prefix must be released */ @@ -498,6 +498,7 @@ out_error_noinode: kfree(sbi->s_bitmap); affs_brelse(root_bh); kfree(sbi->s_prefix); +out_error_free_sbi: kfree(sbi); sb->s_fs_info = NULL; return ret; -- 1.6.4.2