From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Whitehouse Subject: Re: [PATCH 06/12] writeback: remove unused nonblocking and congestion checks (gfs2) Date: Wed, 18 Nov 2009 09:59:46 +0000 Message-ID: <1258538386.2904.7.camel@localhost.localdomain> References: <20091118082648.140755818@intel.com> <20091118082846.170413359@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Andrew Morton , Jens Axboe , linux-fsdevel@vger.kernel.org, LKML To: Wu Fengguang Return-path: Received: from mx1.redhat.com ([209.132.183.28]:11669 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756551AbZKRJ5c (ORCPT ); Wed, 18 Nov 2009 04:57:32 -0500 In-Reply-To: <20091118082846.170413359@intel.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi, That looks ok to me, modulo the warnings below. The only "non-obvious" thing in this area which the GFS2 writepage[s] code relies upon is the assumption that if we have a ->writepages() then ->writepage() will never be called from a context which requires the fs to actually do a write (i.e. the fs can refuse this if required). That is also only the case for journaled data files - normal writes don't have that requirement. CC [M] fs/gfs2/aops.o fs/gfs2/aops.c: In function =E2=80=98gfs2_write_jdata_pagevec=E2=80=99: fs/gfs2/aops.c:272: warning: unused variable =E2=80=98bdi=E2=80=99 fs/gfs2/aops.c: In function =E2=80=98gfs2_write_cache_jdata=E2=80=99: fs/gfs2/aops.c:336: warning: unused variable =E2=80=98bdi=E2=80=99 Once the warnings are fixed: Acked-by: Steven Whitehouse Do you want me to add this patch into my tree, or were you planning to submit via a different tree? Steve. On Wed, 2009-11-18 at 16:26 +0800, Wu Fengguang wrote: > plain text document attachment > (writeback-remove-congested-checks-linux_fs_gfs2_aops.patch) > No one is calling wb_writeback and write_cache_pages with > wbc.nonblocking=3D1 any more. And lumpy pageout will want to do > nonblocking writeback without the congestion wait. >=20 > CC: Steven Whitehouse > Signed-off-by: Wu Fengguang > --- > fs/gfs2/aops.c | 10 ---------- > 1 file changed, 10 deletions(-) >=20 > --- linux.orig/fs/gfs2/aops.c 2009-11-06 09:22:35.000000000 +0800 > +++ linux/fs/gfs2/aops.c 2009-11-06 09:52:15.000000000 +0800 > @@ -313,11 +313,6 @@ static int gfs2_write_jdata_pagevec(stru > =20 > if (ret || (--(wbc->nr_to_write) <=3D 0)) > ret =3D 1; > - if (wbc->nonblocking && bdi_write_congested(bdi)) { > - wbc->encountered_congestion =3D 1; > - ret =3D 1; > - } > - > } > gfs2_trans_end(sdp); > return ret; > @@ -348,11 +343,6 @@ static int gfs2_write_cache_jdata(struct > int scanned =3D 0; > int range_whole =3D 0; > =20 > - if (wbc->nonblocking && bdi_write_congested(bdi)) { > - wbc->encountered_congestion =3D 1; > - return 0; > - } > - > pagevec_init(&pvec, 0); > if (wbc->range_cyclic) { > index =3D mapping->writeback_index; /* Start from prev offset */ >=20 >=20 -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html