From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Whitehouse Subject: Re: [PATCH 06/12] writeback: remove unused nonblocking and congestion checks (gfs2) Date: Wed, 18 Nov 2009 11:13:41 +0000 Message-ID: <1258542821.2904.10.camel@localhost.localdomain> References: <20091118082648.140755818@intel.com> <20091118082846.170413359@intel.com> <1258538386.2904.7.camel@localhost.localdomain> <20091118100941.GA18726@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Andrew Morton , Jens Axboe , "linux-fsdevel@vger.kernel.org" , LKML To: Wu Fengguang Return-path: Received: from mx1.redhat.com ([209.132.183.28]:50145 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751356AbZKRLL0 (ORCPT ); Wed, 18 Nov 2009 06:11:26 -0500 In-Reply-To: <20091118100941.GA18726@localhost> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi, On Wed, 2009-11-18 at 18:09 +0800, Wu Fengguang wrote: > Hi Steven, >=20 > On Wed, Nov 18, 2009 at 05:59:46PM +0800, Steven Whitehouse wrote: > > Hi, > >=20 > > That looks ok to me, modulo the warnings below. The only "non-obvio= us" > > thing in this area which the GFS2 writepage[s] code relies upon is = the > > assumption that if we have a ->writepages() then ->writepage() will > > never be called from a context which requires the fs to actually do= a > > write (i.e. the fs can refuse this if required). That is also only = the > > case for journaled data files - normal writes don't have that > > requirement. >=20 > Thank you for the tips. I don't think pageout() or migration > writeout() has that hard expectation for ->writepage() :) >=20 > > CC [M] fs/gfs2/aops.o > > fs/gfs2/aops.c: In function =E2=80=98gfs2_write_jdata_pagevec=E2=80= =99: > > fs/gfs2/aops.c:272: warning: unused variable =E2=80=98bdi=E2=80=99 > > fs/gfs2/aops.c: In function =E2=80=98gfs2_write_cache_jdata=E2=80=99= : > > fs/gfs2/aops.c:336: warning: unused variable =E2=80=98bdi=E2=80=99 >=20 > Ah sorry! >=20 > > Once the warnings are fixed: > >=20 > > Acked-by: Steven Whitehouse > >=20 > > Do you want me to add this patch into my tree, or were you planning= to > > submit via a different tree? >=20 > Thanks, can you pull the updated patch directly to your tree? >=20 Yes, its in my -nmw tree now. Thanks, Steve. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html