linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Blunck <jblunck@suse.de>
To: linux-fsdevel@vger.kernel.org
Cc: "Linux-Kernel Mailinglist" <linux-kernel@vger.kernel.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	jkacur@redhat.com, "Thomas Gleixner" <tglx@linutronix.de>,
	"Jan Blunck" <jblunck@suse.de>, "Arnd Bergmann" <arnd@arndb.de>,
	"Christoph Hellwig" <hch@infradead.org>,
	"Frédéric Weisbecker" <fweisbec@gmail.com>,
	"Alexander Viro" <viro@zeniv.linux.org.uk>
Subject: [PATCH 1/2] BKL: Remove BKL from default_llseek()
Date: Wed, 18 Nov 2009 17:07:36 +0100	[thread overview]
Message-ID: <1258560457-15129-1-git-send-email-jblunck@suse.de> (raw)

Using the BKL in llseek() does not protect the inode's i_size from
modification since the i_size is protected by a seqlock nowadays. Since
default_llseek() is already using the i_size_read() wrapper it is not the
BKL which is serializing the access here.
The access to file->f_pos is not protected by the BKL either since its
access in vfs_write()/vfs_read() is not protected by any lock. If the BKL
is not protecting anything here it can clearly get removed.

Signed-off-by: Jan Blunck <jblunck@suse.de>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: John Kacur <jkacur@redhat.com>
---
 fs/read_write.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/fs/read_write.c b/fs/read_write.c
index 3ac2898..0e491cc 100644
--- a/fs/read_write.c
+++ b/fs/read_write.c
@@ -107,7 +107,6 @@ loff_t default_llseek(struct file *file, loff_t offset, int origin)
 {
 	loff_t retval;
 
-	lock_kernel();
 	switch (origin) {
 		case SEEK_END:
 			offset += i_size_read(file->f_path.dentry->d_inode);
@@ -128,7 +127,6 @@ loff_t default_llseek(struct file *file, loff_t offset, int origin)
 		retval = offset;
 	}
 out:
-	unlock_kernel();
 	return retval;
 }
 EXPORT_SYMBOL(default_llseek);
-- 
1.6.4.2

             reply	other threads:[~2009-11-18 16:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-18 16:07 Jan Blunck [this message]
2009-11-18 16:07 ` [PATCH 2/2] BKL: Update documentation on llseek( \b) Jan Blunck
2009-11-18 17:15 ` [PATCH 1/2] BKL: Remove BKL from default_llseek() Alan Cox
2009-11-18 17:27   ` Jamie Lokier
2009-11-18 17:33     ` Arnd Bergmann
2009-11-18 18:00       ` Alan Cox
2009-11-18 18:06         ` Arnd Bergmann
2009-11-18 18:14       ` Alan Cox
2009-11-18 19:17         ` Arnd Bergmann
2009-11-18 17:35     ` Oliver Neukum
2009-11-18 17:50       ` Jamie Lokier
2009-11-18 18:16         ` Alan Cox
2009-11-19  2:40           ` Jamie Lokier
2009-11-19 10:13             ` Alan Cox
2009-11-18 17:55       ` Alan Cox
2009-11-18 17:55       ` Jan Blunck
2009-11-18 17:53   ` Jan Blunck
2009-11-18 18:17     ` Alan Cox
2009-11-18 20:02       ` Jan Blunck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1258560457-15129-1-git-send-email-jblunck@suse.de \
    --to=jblunck@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=fweisbec@gmail.com \
    --cc=hch@infradead.org \
    --cc=jkacur@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).