From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Blunck Subject: [PATCH 08/15] airo: Use ppos instead of file->f_pos Date: Fri, 20 Nov 2009 17:40:38 +0100 Message-ID: <1258735245-25826-9-git-send-email-jblunck@suse.de> References: <1258735245-25826-1-git-send-email-jblunck@suse.de> Cc: Linux-Kernel Mailinglist , Andrew Morton , Thomas Gleixner , jkacur@redhat.com, Arnd Bergmann , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Weisbecker?= , Jamie Lokier , Jan Blunck , "John W. Linville" To: linux-fsdevel@vger.kernel.org, Christoph Hellwig , Alan Cox Return-path: In-Reply-To: <1258735245-25826-1-git-send-email-jblunck@suse.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org When updating the priv->writelen value the ppos given to proc_write() should be used instead of file->f_pos. This might lead to a wrong writelen value when pwrite() is used. Signed-off-by: Jan Blunck --- drivers/net/wireless/airo.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c index abf896a..ae7dea8 100644 --- a/drivers/net/wireless/airo.c +++ b/drivers/net/wireless/airo.c @@ -4659,7 +4659,7 @@ static ssize_t proc_write( struct file *file, if (copy_from_user(priv->wbuffer + pos, buffer, len)) return -EFAULT; if ( pos + len > priv->writelen ) - priv->writelen = len + file->f_pos; + priv->writelen = pos + len; *offset = pos + len; return len; } -- 1.6.4.2