From: Jeff Layton <jlayton@redhat.com>
To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: jamie@shareable.org, pavel@ucw.cz, miklos@szeredi.hu,
viro@ZenIV.linux.org.uk, duaneg@dghda.com, ebiederm@xmission.com
Subject: [PATCH 0/2] vfs: plug some holes involving LAST_BIND symlinks and file bind mounts (try #6)
Date: Wed, 2 Dec 2009 14:59:41 -0500 [thread overview]
Message-ID: <1259783983-26884-1-git-send-email-jlayton@redhat.com> (raw)
This patchset is another attempt to add missing dentry revalidations to
certain places in the lookup codepath. The main difference from the last
patchset is:
* I've dropped the patch that added permissions checks when chasing
LAST_BIND symlinks. There's a lot disagreement about whether the
current behavior is even a bug. I'd prefer to see more concensus on
that point before we do anything here.
* I've rejiggered the error handling in this codepath to ensure that the
bind mounts could still be unmounted. Testing showed that returning an
error in do_lookup when a bind-mounted dentry went stale made it
un-unmountable.
Comments and suggestions appreciated...
Jeff Layton (2):
vfs: force reval of target when following LAST_BIND symlinks
vfs: force reval on dentry of bind mounted files on FS_REVAL_DOT
filesystems
fs/namei.c | 56 +++++++++++++++++++++++++++++++++++++++++++++++++++++++-
1 files changed, 55 insertions(+), 1 deletions(-)
next reply other threads:[~2009-12-02 20:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 19:59 Jeff Layton [this message]
2009-12-02 19:59 ` [PATCH 1/2] vfs: force reval of target when following LAST_BIND symlinks Jeff Layton
2009-12-02 23:53 ` Eric W. Biederman
2009-12-03 10:39 ` Miklos Szeredi
2009-12-02 19:59 ` [PATCH 2/2] vfs: force reval on dentry of bind mounted files on FS_REVAL_DOT filesystems Jeff Layton
2009-12-03 0:01 ` Eric W. Biederman
2009-12-03 1:23 ` Jeff Layton
2009-12-03 10:58 ` Miklos Szeredi
2009-12-03 11:11 ` Eric W. Biederman
2009-12-03 11:19 ` Miklos Szeredi
2009-12-03 11:56 ` Eric W. Biederman
2009-12-03 15:21 ` Miklos Szeredi
2009-12-03 15:20 ` Jeff Layton
2009-12-03 18:35 ` Eric W. Biederman
2009-12-03 19:15 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259783983-26884-1-git-send-email-jlayton@redhat.com \
--to=jlayton@redhat.com \
--cc=duaneg@dghda.com \
--cc=ebiederm@xmission.com \
--cc=jamie@shareable.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=pavel@ucw.cz \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).