From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH 2/5] bitops: compile time optimization for hweight_long(CONSTANT) Date: Wed, 03 Feb 2010 19:47:55 +0100 Message-ID: <1265222875.24455.1020.camel@laptop> References: <20100130094515.475881280@intel.com> <20100130094957.692671259@intel.com> <20100201124825.cc024f2a.akpm@linux-foundation.org> <20100203133951.GA24357@localhost> <20100203070825.e36b3932.akpm@linux-foundation.org> <1265210157.24455.646.camel@laptop> <20100203074251.e2caa3f3.akpm@linux-foundation.org> <20100203181425.GB1367@aftab> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Andrew Morton , Wu Fengguang , LKML , Jamie Lokier , Roland Dreier , Al Viro , "linux-fsdevel@vger.kernel.org" , Ingo Molnar , "H. Peter Anvin" To: Borislav Petkov Return-path: In-Reply-To: <20100203181425.GB1367@aftab> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, 2010-02-03 at 19:14 +0100, Borislav Petkov wrote: > alternative("call hweightXX", "popcnt", X86_FEATURE_POPCNT) Make sure to apply a 0xff bitmask to the popcnt r16 call for hweight8(), and hweight64() needs a bit of magic for 32bit, but yes, something like that ought to work nicely.