From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH 2/5] bitops: compile time optimization for hweight_long(CONSTANT) Date: Fri, 05 Feb 2010 13:14:59 +0100 Message-ID: <1265372099.22001.512.camel@laptop> References: <20100203070825.e36b3932.akpm@linux-foundation.org> <1265210157.24455.646.camel@laptop> <20100203074251.e2caa3f3.akpm@linux-foundation.org> <20100203181425.GB1367@aftab> <1265222875.24455.1020.camel@laptop> <4B69D362.10608@zytor.com> <20100204151050.GC32711@aftab> <1265296432.22001.18.camel@laptop> <20100204155419.GD32711@aftab> <1265299457.22001.72.camel@laptop> <20100205121139.GA9044@aftab> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: "H. Peter Anvin" , Andrew Morton , Wu Fengguang , LKML , Jamie Lokier , Roland Dreier , Al Viro , "linux-fsdevel@vger.kernel.org" , Ingo Molnar , Brian Gerst To: Borislav Petkov Return-path: In-Reply-To: <20100205121139.GA9044@aftab> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, 2010-02-05 at 13:11 +0100, Borislav Petkov wrote: > On Thu, Feb 04, 2010 at 05:04:17PM +0100, Peter Zijlstra wrote: > > No, just don't touch hweight_long(), simply provide > > __arch_hweight{8,16,32,64} and all will be well. > > Ok, another day, another version :) > > It is, of course, completely untested but it builds and the asm looks > ok. I think I've addressed all concerns so far. please work against a tree that has: http://lkml.org/lkml/2010/2/4/119 in.