From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Monakhov Subject: [PATCH 4/7] ext2: use nofail variant of inode_setattr() Date: Fri, 19 Feb 2010 22:47:22 +0300 Message-ID: <1266608845-13212-5-git-send-email-dmonakhov@openvz.org> References: <1266608845-13212-1-git-send-email-dmonakhov@openvz.org> <1266608845-13212-2-git-send-email-dmonakhov@openvz.org> <1266608845-13212-3-git-send-email-dmonakhov@openvz.org> <1266608845-13212-4-git-send-email-dmonakhov@openvz.org> Cc: linux-fsdevel@vger.kernel.org, Dmitry Monakhov To: linux-kernel@vger.kernel.org Return-path: In-Reply-To: <1266608845-13212-4-git-send-email-dmonakhov@openvz.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Since inode_change_ok() is now responsible for all necessery checks we may call __inode_setattr() which can not fail. Signed-off-by: Dmitry Monakhov --- fs/ext2/inode.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c index 71b032c..8542b20 100644 --- a/fs/ext2/inode.c +++ b/fs/ext2/inode.c @@ -1463,7 +1463,11 @@ int ext2_setattr(struct dentry *dentry, struct iattr *iattr) if (error) return error; } - error = inode_setattr(inode, iattr); + /* + * All necessery check already done in inode_check_ok(), + * it is safe to use nofail version here. + */ + __inode_setattr(inode, iattr); if (!error && (iattr->ia_valid & ATTR_MODE)) error = ext2_acl_chmod(inode); return error; -- 1.6.6