From: Eric Paris <eparis@redhat.com>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"hch@infradead.org" <hch@infradead.org>,
"jamie@shareable.org" <jamie@shareable.org>,
"rdreier@cisco.com" <rdreier@cisco.com>,
"schwab@linux-m68k.org" <schwab@linux-m68k.org>,
"sfr@canb.auug.org.au" <sfr@canb.auug.org.au>
Subject: Re: [PATCH] vfs: O_* bit numbers uniqueness check fix
Date: Fri, 12 Mar 2010 10:01:27 -0500 [thread overview]
Message-ID: <1268406087.3768.4.camel@localhost> (raw)
In-Reply-To: <20100312134116.GA6502@localhost>
On Fri, 2010-03-12 at 21:41 +0800, Wu Fengguang wrote:
> Follow the comment by Eric:
>
> Until the FMODE_ and O_ bits do not overload I think we need to check
> FMODE_EXEC and FMODE_NONOTIFY (if you have that one) inside fcntl_init()
> as well. I guess I'll send a patch to someone ?Al? to add FMODE_EXEC to
> the list....
>
> CC: Eric Paris <eparis@redhat.com>
> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
> ---
> fs/fcntl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- linux-mm.orig/fs/fcntl.c 2010-03-12 21:27:12.000000000 +0800
> +++ linux-mm/fs/fcntl.c 2010-03-12 21:38:51.000000000 +0800
> @@ -748,7 +748,8 @@ static int __init fcntl_init(void)
> O_TRUNC | O_APPEND | O_NONBLOCK |
> __O_SYNC | O_DSYNC | FASYNC |
> O_DIRECT | O_LARGEFILE | O_DIRECTORY |
> - O_NOFOLLOW | O_NOATIME | O_CLOEXEC
> + O_NOFOLLOW | O_NOATIME | O_CLOEXEC |
> + FMODE_EXEC
> ));
I think we need to update the hweight as well, otherwise I sure hope
this would panic....
-Eric
next prev parent reply other threads:[~2010-03-12 15:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-11 22:11 [patch 4/6] vfs: O_* bit numbers uniqueness check akpm
2010-03-11 23:11 ` Eric Paris
2010-03-12 13:41 ` [PATCH] vfs: O_* bit numbers uniqueness check fix Wu Fengguang
2010-03-12 15:01 ` Eric Paris [this message]
2010-03-12 15:14 ` Wu Fengguang
2010-03-12 15:15 ` Wu Fengguang
2010-03-12 0:39 ` [patch 4/6] vfs: O_* bit numbers uniqueness check Andreas Dilger
2010-03-12 13:42 ` [PATCH] vfs: O_* bit numbers uniqueness check fix 2 Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268406087.3768.4.camel@localhost \
--to=eparis@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=fengguang.wu@intel.com \
--cc=hch@infradead.org \
--cc=jamie@shareable.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=schwab@linux-m68k.org \
--cc=sfr@canb.auug.org.au \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).