From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Paris Subject: Re: [PATCH] vfs: O_* bit numbers uniqueness check fix Date: Fri, 12 Mar 2010 10:01:27 -0500 Message-ID: <1268406087.3768.4.camel@localhost> References: <201003112211.o2BMBLfm013822@imap1.linux-foundation.org> <1268349064.3768.3.camel@localhost> <20100312134116.GA6502@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: "akpm@linux-foundation.org" , "viro@zeniv.linux.org.uk" , "linux-fsdevel@vger.kernel.org" , "davem@davemloft.net" , "hch@infradead.org" , "jamie@shareable.org" , "rdreier@cisco.com" , "schwab@linux-m68k.org" , "sfr@canb.auug.org.au" To: Wu Fengguang Return-path: Received: from mx1.redhat.com ([209.132.183.28]:38902 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932188Ab0CLPCk (ORCPT ); Fri, 12 Mar 2010 10:02:40 -0500 In-Reply-To: <20100312134116.GA6502@localhost> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, 2010-03-12 at 21:41 +0800, Wu Fengguang wrote: > Follow the comment by Eric: > > Until the FMODE_ and O_ bits do not overload I think we need to check > FMODE_EXEC and FMODE_NONOTIFY (if you have that one) inside fcntl_init() > as well. I guess I'll send a patch to someone ?Al? to add FMODE_EXEC to > the list.... > > CC: Eric Paris > Signed-off-by: Wu Fengguang > --- > fs/fcntl.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > --- linux-mm.orig/fs/fcntl.c 2010-03-12 21:27:12.000000000 +0800 > +++ linux-mm/fs/fcntl.c 2010-03-12 21:38:51.000000000 +0800 > @@ -748,7 +748,8 @@ static int __init fcntl_init(void) > O_TRUNC | O_APPEND | O_NONBLOCK | > __O_SYNC | O_DSYNC | FASYNC | > O_DIRECT | O_LARGEFILE | O_DIRECTORY | > - O_NOFOLLOW | O_NOATIME | O_CLOEXEC > + O_NOFOLLOW | O_NOATIME | O_CLOEXEC | > + FMODE_EXEC > )); I think we need to update the hweight as well, otherwise I sure hope this would panic.... -Eric