From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: hch@infradead.org, viro@zeniv.linux.org.uk
Cc: linux-fsdevel@vger.kernel.org, adilger@sun.com, corbet@lwn.net,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: [PATCH -V2 1/3] vfs: Add name to file handle conversion support
Date: Thu, 18 Mar 2010 22:39:02 +0530 [thread overview]
Message-ID: <1268932144-14105-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com> (raw)
In-Reply-To: <1268932144-14105-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
fs/open.c | 80 ++++++++++++++++++++++++++++++++++++++++++++++++++++
include/linux/fs.h | 7 ++++
2 files changed, 87 insertions(+), 0 deletions(-)
diff --git a/fs/open.c b/fs/open.c
index e17f544..7012cf9 100644
--- a/fs/open.c
+++ b/fs/open.c
@@ -30,6 +30,7 @@
#include <linux/falloc.h>
#include <linux/fs_struct.h>
#include <linux/ima.h>
+#include <linux/exportfs.h>
#include "internal.h"
@@ -1206,3 +1207,82 @@ int nonseekable_open(struct inode *inode, struct file *filp)
}
EXPORT_SYMBOL(nonseekable_open);
+
+/* limit the handle size to some value */
+#define MAX_HANDLE_SZ 4096
+static int do_sys_name_to_handle(const char __user *name,
+ struct file_handle *fh)
+{
+ int retval;
+ int handle_size;
+ struct path path;
+ struct inode *inode;
+ void *handle = NULL;
+
+ if (fh->handle_size > MAX_HANDLE_SZ)
+ return -EINVAL;
+
+ retval = user_lpath(name, &path);
+ if (retval)
+ return retval;
+
+ inode = path.dentry->d_inode;
+ /*
+ * name to handle conversion only done for regular files
+ * directories and symbolic links
+ */
+ if (!S_ISREG(inode->i_mode) && !S_ISDIR(inode->i_mode) &&
+ !S_ISLNK(inode->i_mode)) {
+ retval = -EINVAL;
+ goto err_out;
+ }
+ handle = kmalloc(fh->handle_size, GFP_KERNEL);
+ if (!handle) {
+ retval = -ENOMEM;
+ goto err_out;
+ }
+
+ handle_size = fh->handle_size;
+ /* we ask for a non connected handle */
+ retval = exportfs_encode_fh(path.dentry, (struct fid *)handle,
+ &handle_size, 0);
+ /* convert handle size to bytes */
+ handle_size *= sizeof(u32);
+ fh->handle_type = retval;
+ if (handle_size <= fh->handle_size) {
+ if (copy_to_user(fh->f_handle, handle,
+ handle_size))
+ retval = -EFAULT;
+ else
+ retval = 0;
+ } else
+ retval = -EOVERFLOW;
+ fh->handle_size = handle_size;
+ kfree(handle);
+
+err_out:
+ path_put(&path);
+ return retval;
+}
+
+SYSCALL_DEFINE2(name_to_handle, const char __user *, name,
+ struct file_handle __user *, handle)
+{
+ long ret;
+ struct file_handle f_handle;
+ if (copy_from_user(&f_handle, handle, sizeof(struct file_handle))) {
+ ret = -EFAULT;
+ goto err_out;
+ }
+ ret = do_sys_name_to_handle(name, &f_handle);
+ if (copy_to_user(&handle->handle_type,
+ &f_handle.handle_type, sizeof(f_handle.handle_type)) ||
+ copy_to_user(&handle->handle_size,
+ &f_handle.handle_size, sizeof(f_handle.handle_size))) {
+ ret = -EFAULT;
+ }
+err_out:
+ /* avoid REGPARM breakage on x86: */
+ asmlinkage_protect(2, ret, name, handle);
+ return ret;
+}
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 10b8ded..e618cac 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -948,6 +948,13 @@ struct file {
unsigned long f_mnt_write_state;
#endif
};
+
+struct file_handle {
+ int handle_size;
+ int handle_type;
+ void *f_handle;
+};
+
extern spinlock_t files_lock;
#define file_list_lock() spin_lock(&files_lock);
#define file_list_unlock() spin_unlock(&files_lock);
--
1.7.0.2.273.gc2413
next prev parent reply other threads:[~2010-03-18 17:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 17:09 [PATCH -V2] Generic name to handle and open by handle syscalls Aneesh Kumar K.V
2010-03-18 17:09 ` Aneesh Kumar K.V [this message]
2010-03-18 17:09 ` [PATCH -V2 2/3] vfs: Add open by file handle support Aneesh Kumar K.V
2010-03-18 17:09 ` [PATCH -V2 3/3] x86: Add new syscalls for x86_32 Aneesh Kumar K.V
2010-03-18 17:31 ` [PATCH -V2] Generic name to handle and open by handle syscalls Christoph Hellwig
2010-03-18 17:54 ` J. Bruce Fields
2010-03-29 7:12 ` Aneesh Kumar K. V
2010-03-30 19:36 ` Andreas Dilger
2010-03-18 22:26 ` Andreas Dilger
2010-03-19 6:00 ` Aneesh Kumar K. V
2010-03-26 0:42 ` Ben Hutchings
2010-03-26 6:43 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268932144-14105-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=adilger@sun.com \
--cc=corbet@lwn.net \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).