From: Peter Zijlstra <peterz@infradead.org>
To: Changli Gao <xiaosuo@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Paul Menage <menage@google.com>, Li Zefan <lizf@cn.fujitsu.com>,
Ingo Molnar <mingo@elte.hu>,
Davide Libenzi <davidel@xmailserver.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org
Subject: Re: [PATCH v2] wait: use wrapper functions
Date: Fri, 07 May 2010 12:12:14 +0200 [thread overview]
Message-ID: <1273227134.1642.334.camel@laptop> (raw)
In-Reply-To: <1273214006-2979-1-git-send-email-xiaosuo@gmail.com>
On Fri, 2010-05-07 at 14:33 +0800, Changli Gao wrote:
> use wrapper functions
>
> epoll should not touch flags in wait_queue_t. This patch introduces a new
> function __add_wait_queue_excl(), for the users, who use wait queue as a
> LIFO queue.
>
> __add_wait_queue_tail_excl() is introduced too instead of
> add_wait_queue_exclusive_locked(). remove_wait_queue_locked() is removed, as
> it is a duplicate of __remove_wait_queue(), disliked by users, and with less
> users.
>
> Signed-off-by: Changli Gao <xiaosuo@gmail.com>
Looks good to me. I can feed it to Ingo if he doesn't pick it up
himself.
next prev parent reply other threads:[~2010-05-07 10:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 6:33 [PATCH v2] wait: use wrapper functions Changli Gao
2010-05-07 10:12 ` Peter Zijlstra [this message]
[not found] ` <1273214006-2979-1-git-send-email-xiaosuo-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-05-07 20:52 ` Andrew Morton
2010-05-07 20:56 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273227134.1642.334.camel@laptop \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.linux-foundation.org \
--cc=davidel@xmailserver.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=mingo@elte.hu \
--cc=viro@zeniv.linux.org.uk \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).