From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH v2] wait: use wrapper functions Date: Fri, 07 May 2010 12:12:14 +0200 Message-ID: <1273227134.1642.334.camel@laptop> References: <1273214006-2979-1-git-send-email-xiaosuo@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Andrew Morton , Alexander Viro , Paul Menage , Li Zefan , Ingo Molnar , Davide Libenzi , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org To: Changli Gao Return-path: In-Reply-To: <1273214006-2979-1-git-send-email-xiaosuo@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, 2010-05-07 at 14:33 +0800, Changli Gao wrote: > use wrapper functions > > epoll should not touch flags in wait_queue_t. This patch introduces a new > function __add_wait_queue_excl(), for the users, who use wait queue as a > LIFO queue. > > __add_wait_queue_tail_excl() is introduced too instead of > add_wait_queue_exclusive_locked(). remove_wait_queue_locked() is removed, as > it is a duplicate of __remove_wait_queue(), disliked by users, and with less > users. > > Signed-off-by: Changli Gao Looks good to me. I can feed it to Ingo if he doesn't pick it up himself.