From: Changli Gao <xiaosuo@gmail.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Changli Gao <xiaosuo@gmail.com>
Subject: [PATCH 2/2] fs: optimize mpage_bio_submit()
Date: Sat, 29 May 2010 09:19:26 +0800 [thread overview]
Message-ID: <1275095966-18382-1-git-send-email-xiaosuo@gmail.com> (raw)
optimize mpage_bio_submit()
check rw, then initialize bio->bi_end_io.
Signed-off-by: Changli Gao <xiaosuo@gmail.com>
----
fs/mpage.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/mpage.c b/fs/mpage.c
index 94ff0d1..632681c 100644
--- a/fs/mpage.c
+++ b/fs/mpage.c
@@ -85,9 +85,7 @@ static void mpage_end_io_write(struct bio *bio, int err)
static struct bio *mpage_bio_submit(int rw, struct bio *bio)
{
- bio->bi_end_io = mpage_end_io_read;
- if (rw == WRITE)
- bio->bi_end_io = mpage_end_io_write;
+ bio->bi_end_io = rw != WRITE ? mpage_end_io_read : mpage_end_io_write;
submit_bio(rw, bio);
return NULL;
}
next reply other threads:[~2010-05-29 1:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-29 1:19 Changli Gao [this message]
2010-05-29 12:47 ` [PATCH 2/2] fs: optimize mpage_bio_submit() Borislav Petkov
2010-05-29 13:33 ` Changli Gao
2010-05-29 13:43 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275095966-18382-1-git-send-email-xiaosuo@gmail.com \
--to=xiaosuo@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).