From: Steven Rostedt <rostedt@goodmis.org>
To: Changli Gao <xiaosuo@gmail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
axboe@kernel.dk, Al Viro <viro@zeniv.linux.org.uk>,
mszeredi@suse.cz, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v2 3/4]: sendfile: remove flags paramter of do_splice_direct()
Date: Sat, 29 May 2010 20:39:20 -0400 [thread overview]
Message-ID: <1275179960.4825.1.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <AANLkTim6tj4OKnLGW2dDIsvAmeU6b9Qsi6IZKdvlKHV2@mail.gmail.com>
On Sun, 2010-05-30 at 07:58 +0800, Changli Gao wrote:
> On Sun, May 30, 2010 at 12:20 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > [ Removed matthew@wil.cx since I'm getting errors in sending to that address ]
> >
> But why not use (file->f_flags & O_NONBLOCK) instead, as
> tracing_splice_read_pipe() does?
Probably because I copied the code from something that used
SPLICE_F_NONBLOCK ;-)
But userspace passes that flag too. Although, maybe I just don't
understand the API fully.
-- Steve
next prev parent reply other threads:[~2010-05-30 0:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 14:44 [PATCH v2 3/4]: sendfile: remove flags paramter of do_splice_direct() Changli Gao
2010-05-28 9:40 ` Miklos Szeredi
2010-05-28 10:06 ` Changli Gao
2010-05-29 1:59 ` Changli Gao
2010-05-29 16:20 ` Steven Rostedt
2010-05-29 23:58 ` Changli Gao
2010-05-30 0:39 ` Steven Rostedt [this message]
2010-05-30 3:25 ` Changli Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275179960.4825.1.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=axboe@kernel.dk \
--cc=eric.dumazet@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=mingo@redhat.com \
--cc=mszeredi@suse.cz \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).