From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [patch v2] fcntl: return -EFAULT if copy_to_user fails
Date: Thu, 03 Jun 2010 15:42:43 +0200
Message-ID: <1275572563.2456.37.camel@edumazet-laptop>
References: <20100603100402.GR5483@bicker> <4C07826A.6060302@oss.ntt.co.jp>
	 <20100603103542.GV5483@bicker> <4C07990A.8080508@fusionio.com>
	 <4C079D34.5010500@oss.ntt.co.jp> <1275568683.2456.33.camel@edumazet-laptop>
	 <20100603131031.GM6822@laptop>  <4C07AD0C.8090409@oss.ntt.co.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Nick Piggin <npiggin@suse.de>, Jens Axboe <jaxboe@fusionio.com>,
	Dan Carpenter <error27@gmail.com>,
	Matthew Wilcox <matthew@wil.cx>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Andrew Morton <akpm@linux-foundation.org>,
	Oleg Nesterov <oleg@redhat.com>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <4C07AD0C.8090409@oss.ntt.co.jp>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

Le jeudi 03 juin 2010 =C3=A0 22:24 +0900, Takuya Yoshikawa a =C3=A9crit=
 :
> (2010/06/03 22:10), Nick Piggin wrote:
> > On Thu, Jun 03, 2010 at 02:38:03PM +0200, Eric Dumazet wrote:

> >> This is really ugly.
> >>
> >> static inline int sec_copy_to_user(arg1, arg2, arg3)
> >> {
> >> 	int res =3D copy_to_user(arg1, arg2, arg3);
> >>
> >> 	return (res>  0) ? -EFAULT : res;
> >> }
> >
> > It would be unfortunate if it adds more confusion. I'd prefer to ha=
ve
> > a sufficiently different name. memcpy_to_user/memcpy_from_user
> > perhaps?
>=20
> Then, and memclear_user() ?
>=20
> >
>=20

We are interested by the fact that full copy is done, so maybe use the
'full' prefix ?

fullcopy_to_user() , fullclear_user() ?