From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [patch 24/52] fs: dcache reduce d_parent locking Date: Thu, 24 Jun 2010 10:44:22 +0200 Message-ID: <1277369062.1875.928.camel@laptop> References: <20100624030212.676457061@suse.de> <20100624030729.395195069@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, John Stultz , Frank Mayhar , "Paul E.McKenney" To: npiggin@suse.de Return-path: In-Reply-To: <20100624030729.395195069@suse.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, 2010-06-24 at 13:02 +1000, npiggin@suse.de wrote: > Use RCU property of dcache to simplify locking in some places where we > take d_parent and d_lock. > > Comment: don't need rcu_deref because we take the spinlock and recheck it. But does the LOCK barrier imply a DATA DEPENDENCY barrier? (It does on x86, and the compiler barrier implied by spin_lock() suffices to replace ACCESS_ONCE()).