From: Davidlohr Bueso <dave.bueso@gmail.com>
To: me@bobcopeland.com, linux-karma-devel@lists.sourceforge.net
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] omfs: fix memory leak
Date: Sat, 03 Jul 2010 22:33:48 -0400 [thread overview]
Message-ID: <1278210828.27014.2.camel@cowboy> (raw)
Hi,
In omfs_fill_super(), when returning on error, sbi is not being freed.
Thanks,
Davidlohr.
Signed-off-by: Davidlohr Bueso <dave@gnu.org>
---
fs/omfs/inode.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c
index 089839a..253846e 100644
--- a/fs/omfs/inode.c
+++ b/fs/omfs/inode.c
@@ -523,12 +523,14 @@ static int omfs_fill_super(struct super_block *sb, void *data, int silent)
}
printk(KERN_DEBUG "omfs: Mounted volume %s\n", omfs_rb->r_name);
- ret = 0;
+ ret = 0; /* success */
out_brelse_bh2:
brelse(bh2);
out_brelse_bh:
brelse(bh);
end:
+ if (ret != 0)
+ kfree(sbi);
return ret;
}
--
1.7.0.4
------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
next reply other threads:[~2010-07-04 2:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-04 2:33 Davidlohr Bueso [this message]
2010-07-04 11:37 ` [PATCH] omfs: fix memory leak me
2010-07-05 5:12 ` Davidlohr Bueso
2010-07-05 14:00 ` me
2010-07-06 4:50 ` [linux-karma-devel] " Davidlohr Bueso
2010-07-06 15:45 ` me
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278210828.27014.2.camel@cowboy \
--to=dave.bueso@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-karma-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=me@bobcopeland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).